Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IF Node): Fix typo in combine description (no-changelog) #5964

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

filp
Copy link
Contributor

@filp filp commented Apr 12, 2023

Apologies, I'm not a fan of PRs fixing nothing but typos, but I've been looking at these for a while and couldn't come up with any other work to bundle them with yet 😬

Fixes a couple of typos in node instructions.

N8N is great by the way, huge fan 🚀

@CLAassistant
Copy link

CLAassistant commented Apr 12, 2023

CLA assistant check
All committers have signed the CLA.

@n8n-assistant n8n-assistant bot added community Authored by a community member core Enhancement outside /nodes-base and /editor-ui node/improvement New feature or request labels Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0b48088) 18.07% compared to head (9622ddb) 18.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5964   +/-   ##
=======================================
  Coverage   18.07%   18.07%           
=======================================
  Files        2540     2540           
  Lines      115409   115409           
  Branches    17991    17991           
=======================================
  Hits        20860    20860           
  Misses      93921    93921           
  Partials      628      628           
Impacted Files Coverage Δ
packages/nodes-base/nodes/If/If.node.ts 62.36% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Joffcom Joffcom changed the title fix: Correct annoying typos in IF node fix(If Node): Fix typo in combine description (no-changelog) Apr 14, 2023
@Joffcom Joffcom changed the title fix(If Node): Fix typo in combine description (no-changelog) fix(IF Node): Fix typo in combine description (no-changelog) Apr 14, 2023
@Joffcom
Copy link
Member

Joffcom commented Apr 14, 2023

Hey @filp,

Thanks for the PR, This was bugging me as well but I have not found some time to get it sorted. Once the tests are happy I will get this one merged in and we can both be a lot happier 🙌🏻

@Joffcom Joffcom added node/improvement New feature or request and removed core Enhancement outside /nodes-base and /editor-ui node/improvement New feature or request labels Apr 14, 2023
@Joffcom Joffcom merged commit 18d5156 into n8n-io:master Apr 14, 2023
MiloradFilipovic added a commit that referenced this pull request Apr 18, 2023
* master: (30 commits)
  feat(core): Add versionControl feature flag (#6000)
  fix: Small changes to user activation modal (no-changelog) (#5962)
  fix(editor): Cleanup demo/video experiment (#5974)
  feat: Add variables feature (#5602)
  ci: Improve test for wait node (#5997)
  fix(editor): Fix moving canvas on middle click preventing lasso selection (#5996)
  fix(HTTP Request Node): Fix itemIndex in HTTP Request errors (#5991)
  refactor(editor): Refactor history and debounce mixins to composables (no-changelog) (#5930)
  feat(GitLab Node): Add Additional parameters for File List (#5621)
  build: Update license SDK to v2.1.0 (no-changelog) (#5987)
  fix(OpenAI Node): Update OpenAI Text Moderate input placeholder text (#5823)
  fix(Code Node): Handle user code returning `null` and `undefined` (#5989)
  fix(Google Sheets Trigger Node): Return actual error message
  fix(core): Make `getExecutionId` available on all nodes types (#5990)
  ci: Add checklist item hinting at not adding new dependencies for nodes (no-changelog) (#5985)
  fix(core): Improve SAML connection test result views (#5981)
  fix(IF Node): Fix typo in combine description (no-changelog) (#5964)
  ci: Add a workflow to push n8n releases to release channels (no-changelog) (#5839)
  fix(editor): Make sure to redirect to blank canvas after personalisation modal (#5980)
  fix(core): Fix paired item returning wrong data (#5898)
  ...

# Conflicts:
#	packages/editor-ui/src/Interface.ts
MiloradFilipovic added a commit that referenced this pull request Apr 18, 2023
…rce-mapper-ui

* feature/resource-mapping-component: (30 commits)
  feat(core): Add versionControl feature flag (#6000)
  fix: Small changes to user activation modal (no-changelog) (#5962)
  fix(editor): Cleanup demo/video experiment (#5974)
  feat: Add variables feature (#5602)
  ci: Improve test for wait node (#5997)
  fix(editor): Fix moving canvas on middle click preventing lasso selection (#5996)
  fix(HTTP Request Node): Fix itemIndex in HTTP Request errors (#5991)
  refactor(editor): Refactor history and debounce mixins to composables (no-changelog) (#5930)
  feat(GitLab Node): Add Additional parameters for File List (#5621)
  build: Update license SDK to v2.1.0 (no-changelog) (#5987)
  fix(OpenAI Node): Update OpenAI Text Moderate input placeholder text (#5823)
  fix(Code Node): Handle user code returning `null` and `undefined` (#5989)
  fix(Google Sheets Trigger Node): Return actual error message
  fix(core): Make `getExecutionId` available on all nodes types (#5990)
  ci: Add checklist item hinting at not adding new dependencies for nodes (no-changelog) (#5985)
  fix(core): Improve SAML connection test result views (#5981)
  fix(IF Node): Fix typo in combine description (no-changelog) (#5964)
  ci: Add a workflow to push n8n releases to release channels (no-changelog) (#5839)
  fix(editor): Make sure to redirect to blank canvas after personalisation modal (#5980)
  fix(core): Fix paired item returning wrong data (#5898)
  ...
@janober
Copy link
Member

janober commented Apr 20, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants