Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): App should not crash with a custom rest endpoint #5911

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Apr 5, 2023

fixes #5880

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Apr 5, 2023
@netroy netroy force-pushed the fix-custom-rest-endpoint branch from 0610a7a to 9b4acaa Compare April 5, 2023 16:33
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch coverage: 45.45% and no project coverage change.

Comparison is base (dba5be3) 17.52% compared to head (9b4acaa) 17.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5911   +/-   ##
=======================================
  Coverage   17.52%   17.52%           
=======================================
  Files        2495     2495           
  Lines      114289   114289           
  Branches    17852    17852           
=======================================
  Hits        20027    20027           
  Misses      93671    93671           
  Partials      591      591           
Impacted Files Coverage Δ
packages/cli/src/Server.ts 0.00% <0.00%> (ø)
packages/cli/src/commands/start.ts 0.00% <0.00%> (ø)
packages/editor-ui/src/stores/n8nRootStore.ts 70.90% <57.14%> (+1.61%) ⬆️
packages/editor-ui/src/Interface.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

✅ All Cypress E2E specs passed

@netroy netroy merged commit 2881ee9 into master Apr 6, 2023
@netroy netroy deleted the fix-custom-rest-endpoint branch April 6, 2023 09:35
@janober
Copy link
Member

janober commented Apr 19, 2023

Got released with [email protected]

sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom rest endpoint
3 participants