Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Support backspacing with modifier key #5845

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Mar 30, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (d0788ee) 14.99% compared to head (f3d115a) 14.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5845      +/-   ##
==========================================
- Coverage   14.99%   14.99%   -0.01%     
==========================================
  Files        2476     2476              
  Lines      113392   113404      +12     
  Branches    17736    17738       +2     
==========================================
+ Hits        17003    17004       +1     
- Misses      95811    95822      +11     
  Partials      578      578              
Impacted Files Coverage Δ
...ui/src/components/CodeNodeEditor/baseExtensions.ts 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ivov ivov merged commit 11692c5 into master Mar 31, 2023
@ivov ivov deleted the ado-453-code-node-deletes-code-if-you-minimise branch March 31, 2023 07:19
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 31, 2023
believe-Mahesh pushed a commit to believe-Mahesh/n8n that referenced this pull request Apr 4, 2023
@janober
Copy link
Member

janober commented Apr 19, 2023

Got released with [email protected]

sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system Upcoming Release Will be part of the upcoming release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants