Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Schedule Trigger Node): Linking to crontab.guru examples (no-changelog) #5834

Merged
merged 3 commits into from
Mar 30, 2023

Conversation

maspio
Copy link
Contributor

@maspio maspio commented Mar 30, 2023

Github issue / Community forum post (link here to close automatically):

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Mar 30, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (9e9003b) 14.83% compared to head (db68d1b) 14.80%.

❗ Current head db68d1b differs from pull request most recent head d92dc81. Consider uploading reports for the commit d92dc81 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5834      +/-   ##
==========================================
- Coverage   14.83%   14.80%   -0.03%     
==========================================
  Files        2475     2475              
  Lines      113363   113363              
  Branches    17702    17703       +1     
==========================================
- Hits        16820    16789      -31     
- Misses      95999    96030      +31     
  Partials      544      544              
Impacted Files Coverage Δ
.../nodes-base/nodes/Schedule/ScheduleTrigger.node.ts 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maspio maspio merged commit 6f72091 into master Mar 30, 2023
@maspio maspio deleted the node-337-our-help-link-from-the-schedule-node-is branch March 30, 2023 11:07
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 30, 2023
believe-Mahesh pushed a commit to believe-Mahesh/n8n that referenced this pull request Apr 4, 2023
…ngelog) (n8n-io#5834)

linking to crontab.guru examples instead of cronmaker.com

Co-authored-by: Jon <[email protected]>
@janober
Copy link
Member

janober commented Apr 19, 2023

Got released with [email protected]

sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
…ngelog) (n8n-io#5834)

linking to crontab.guru examples instead of cronmaker.com

Co-authored-by: Jon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released Upcoming Release Will be part of the upcoming release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants