Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Show correct status on canceled executions #5813

Merged
merged 4 commits into from
Mar 30, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Mar 29, 2023

In ExecutionsList
image

In ExecutionPreview
image

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Files matching packages/editor-ui/src/mixins/**:

  • Avoided adding new mixins (use composables instead). Only removed code from here.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Mar 29, 2023
@netroy netroy force-pushed the fix-editor-canceled-status branch from 01a87c7 to 7ddde37 Compare March 29, 2023 18:18
@netroy netroy force-pushed the fix-editor-canceled-status branch from 7ddde37 to 06b8468 Compare March 29, 2023 18:21
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (744c3fd) 14.84% compared to head (b38a793) 14.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5813      +/-   ##
==========================================
- Coverage   14.84%   14.84%   -0.01%     
==========================================
  Files        2475     2475              
  Lines      113363   113359       -4     
  Branches    17702    17703       +1     
==========================================
- Hits        16826    16823       -3     
- Misses      95990    95991       +1     
+ Partials      547      545       -2     
Impacted Files Coverage Δ
packages/editor-ui/src/mixins/executionsHelpers.ts 37.80% <0.00%> (+3.36%) ⬆️

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MiloradFilipovic MiloradFilipovic self-requested a review March 30, 2023 10:00
@netroy netroy merged commit d0788ee into master Mar 30, 2023
@netroy netroy deleted the fix-editor-canceled-status branch March 30, 2023 14:27
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 30, 2023
netroy added a commit that referenced this pull request Apr 3, 2023
believe-Mahesh pushed a commit to believe-Mahesh/n8n that referenced this pull request Apr 4, 2023
@janober
Copy link
Member

janober commented Apr 19, 2023

Got released with [email protected]

@janober
Copy link
Member

janober commented Apr 19, 2023

Got released with [email protected]

sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released skip-e2e ui Enhancement in /editor-ui or /design-system Upcoming Release Will be part of the upcoming release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants