Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix saml.api.test.ts (no-changelog) #5764

Merged
merged 2 commits into from
Mar 23, 2023
Merged

ci: Fix saml.api.test.ts (no-changelog) #5764

merged 2 commits into from
Mar 23, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Mar 23, 2023

No description provided.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Mar 23, 2023
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage: 54.83% and no project coverage change.

Comparison is base (d3a34ab) 14.41% compared to head (f689d4e) 14.41%.

❗ Current head f689d4e differs from pull request most recent head 0097ce8. Consider uploading reports for the commit 0097ce8 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5764   +/-   ##
=======================================
  Coverage   14.41%   14.41%           
=======================================
  Files        2469     2470    +1     
  Lines      113064   113079   +15     
  Branches    17597    17598    +1     
=======================================
+ Hits        16299    16305    +6     
- Misses      96248    96257    +9     
  Partials      517      517
Impacted Files Coverage Δ
packages/cli/src/sso/saml/saml.service.ee.ts 0.00% <0.00%> (ø)
packages/nodes-base/nodes/Ftp/Ftp.node.ts 0.00% <0.00%> (ø)
packages/nodes-base/nodes/Ssh/Ssh.node.ts 0.00% <0.00%> (ø)
packages/nodes-base/nodes/Wait/Wait.node.ts 0.00% <0.00%> (ø)
packages/nodes-base/nodes/Webhook/Webhook.node.ts 0.00% <0.00%> (ø)
packages/workflow/src/Interfaces.ts 50.00% <ø> (ø)
packages/core/src/NodeExecuteFunctions.ts 10.66% <33.33%> (+0.17%) ⬆️
packages/cli/src/controllers/users.controller.ts 79.38% <50.00%> (-1.35%) ⬇️
...kages/cli/src/middlewares/userManagementEnabled.ts 100.00% <100.00%> (ø)
packages/cli/src/sso/saml/samlHelpers.ts 33.33% <100.00%> (ø)
... and 1 more

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@netroy netroy merged commit 4c583e2 into master Mar 23, 2023
@netroy netroy deleted the fix-master branch March 23, 2023 15:54
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 23, 2023
MiloradFilipovic added a commit that referenced this pull request Mar 23, 2023
@MiloradFilipovic
Merge branch 'master' into feature/resource-mapping-component
8f3cb59 
* master:
  ci: Fix saml.api.test.ts (no-changelog) (#5764)
  docs: Refer to docker.n8n.io/n8nio/n8n for pulling n8n docker images (no-changelog) (#5763)
  🚀 Release 0.221.0 (#5726)
  fix(core): Persist CurrentAuthenticationMethod setting change (#5762)
  feat(core): Limit user invites when SAML is enabled (#5761)
  fix(core): Setup nodeHelpers that aren't exposed in the code sandbox (no-changelog) (#5753)
  fix(HTTP Request Node): Fix AWS credentials to automatically deconstruct the url (#5751)
  fix(core): Require Auth on icons and nodes/credentials types static files (no-changelog) (#5745)
  fix(Split In Batches Node): Roll back changes in v1 and create v2 (#5747)
MiloradFilipovic added a commit that referenced this pull request Mar 23, 2023
@MiloradFilipovic
Merge branch 'feature/resource-mapping-component' into node-396-postg…
e3d4ff5 
…res-node-resorce-mapper

* feature/resource-mapping-component:
  ci: Fix saml.api.test.ts (no-changelog) (#5764)
  docs: Refer to docker.n8n.io/n8nio/n8n for pulling n8n docker images (no-changelog) (#5763)
  🚀 Release 0.221.0 (#5726)
  fix(core): Persist CurrentAuthenticationMethod setting change (#5762)
  feat(core): Limit user invites when SAML is enabled (#5761)
  fix(core): Setup nodeHelpers that aren't exposed in the code sandbox (no-changelog) (#5753)
  fix(HTTP Request Node): Fix AWS credentials to automatically deconstruct the url (#5751)
  fix(core): Require Auth on icons and nodes/credentials types static files (no-changelog) (#5745)
  fix(Split In Batches Node): Roll back changes in v1 and create v2 (#5747)
MiloradFilipovic added a commit that referenced this pull request Mar 24, 2023
@MiloradFilipovic
Merge branch 'master' into N8N-5677-refactor-workflows-store
c35c34a 
* master: (80 commits)
  feat: Execution custom data saving and filtering (#5496)
  ci: Fix saml.api.test.ts (no-changelog) (#5764)
  docs: Refer to docker.n8n.io/n8nio/n8n for pulling n8n docker images (no-changelog) (#5763)
  🚀 Release 0.221.0 (#5726)
  fix(core): Persist CurrentAuthenticationMethod setting change (#5762)
  feat(core): Limit user invites when SAML is enabled (#5761)
  fix(core): Setup nodeHelpers that aren't exposed in the code sandbox (no-changelog) (#5753)
  fix(HTTP Request Node): Fix AWS credentials to automatically deconstruct the url (#5751)
  fix(core): Require Auth on icons and nodes/credentials types static files (no-changelog) (#5745)
  fix(Split In Batches Node): Roll back changes in v1 and create v2 (#5747)
  fix(editor): Use credentials when fetching node and credential types (#5760)
  fix: Update Posthog no-capture (#5693)
  fix(core): Return SAML service provider urls with config (#5759)
  fix(HTTP Request Node): Fix AWS credentials to automatically deconstruct the url (#5751)
  feat(editor): Fix ResourceLocator dropdown style (#5714)
  feat(Filter Node): New node
  fix(core): Require Auth on icons and nodes/credentials types static files (no-changelog) (#5745)
  refactor(core): Stop importing LoggerProxy and createDeferredPromise in nodes-base (no-changelog) (#5742)
  feat(core): Make OAuth2 error handling consistent with success handling (#5555)
  fix(Split In Batches Node): Roll back changes in v1 and create v2 (#5747)
  ...
@janober
Copy link
Member

janober commented Mar 30, 2023

Got released with [email protected]

sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
@netroy @sunilrr
ci: Fix saml.api.test.ts (no-changelog) (n8n-io#5764)
ba6e920
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flipswitchingmonkey flipswitchingmonkey flipswitchingmonkey approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released skip-e2e Upcoming Release Will be part of the upcoming release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@netroy @janober @flipswitchingmonkey