Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(Date & Time Node): Skip the test when local timezone is not in UTC (no-changelog) #5735

Merged
merged 1 commit into from
Mar 20, 2023
Merged

test(Date & Time Node): Skip the test when local timezone is not in UTC (no-changelog) #5735

merged 1 commit into from
Mar 20, 2023

Conversation

agobrech
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@agobrech agobrech changed the title test(Node DateTime): Skip the test when local timezone is not in UTC(no-changelog) test(DateTime Node): Skip the test when local timezone is not in UTC(no-changelog) Mar 20, 2023
@agobrech agobrech changed the title test(DateTime Node): Skip the test when local timezone is not in UTC(no-changelog) test(Date & Time Node): Skip the test when local timezone is not in UTC(no-changelog) Mar 20, 2023
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Mar 20, 2023
@agobrech agobrech changed the title test(Date & Time Node): Skip the test when local timezone is not in UTC(no-changelog) test(Date & Time Node): Skip the test when local timezone is not in UTC (no-changelog) Mar 20, 2023
@agobrech agobrech merged commit 46d013c into master Mar 20, 2023
@agobrech agobrech deleted the node-404-fix-datetime-tests-running-when-timezone-utc branch March 20, 2023 15:55
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 20, 2023
@janober
Copy link
Member

janober commented Mar 30, 2023

Got released with [email protected]

sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
@agobrech @sunilrr
test(Date & Time Node): Skip the test when local timezone is not in U…
619071b 
…TC (no-changelog) (n8n-io#5735)

Check for moment default timezone in dateTime tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maspio maspio maspio approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released Upcoming Release Will be part of the upcoming release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agobrech @janober @maspio