Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): SSO login button #5615

Merged
merged 5 commits into from
Mar 17, 2023

Conversation

cstuncsik
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Mar 3, 2023
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Files matching packages/design-system/**/*.vue:

  • Used design system tokens (colors, spacings...) where possible.
  • Updated Storybook with new component or updated functionality.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage: 21.53% and project coverage change: +1.33 🎉

Comparison is base (02e3581) 13.08% compared to head (846f4d5) 14.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5615      +/-   ##
==========================================
+ Coverage   13.08%   14.41%   +1.33%     
==========================================
  Files        2462     2465       +3     
  Lines      112715   112838     +123     
  Branches    17502    17527      +25     
==========================================
+ Hits        14744    16270    +1526     
+ Misses      97471    96061    -1410     
- Partials      500      507       +7     
Impacted Files Coverage Δ
...ages/cli/src/sso/saml/routes/saml.controller.ee.ts 22.80% <0.00%> (-1.34%) ⬇️
packages/editor-ui/src/api/sso.ts 0.00% <0.00%> (ø)
packages/editor-ui/src/router.ts 0.00% <0.00%> (ø)
packages/editor-ui/src/stores/sso.ts 0.00% <0.00%> (ø)
packages/editor-ui/src/stores/settings.ts 58.46% <85.71%> (+0.51%) ⬆️
packages/editor-ui/src/Interface.ts 100.00% <100.00%> (+100.00%) ⬆️
packages/editor-ui/src/constants.ts 97.77% <100.00%> (+<0.01%) ⬆️

... and 29 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cstuncsik cstuncsik marked this pull request as ready for review March 17, 2023 20:05
@cstuncsik cstuncsik merged commit 6916628 into master Mar 17, 2023
@cstuncsik cstuncsik deleted the pay-180-add-button-to-login-page-with-sign-in branch March 17, 2023 20:07
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 17, 2023
@janober
Copy link
Member

janober commented Mar 26, 2023

Got released with [email protected]

@janober
Copy link
Member

janober commented Mar 26, 2023

Got released with [email protected]

sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
* feat(editor): SSO login button

* feat(editor): SSO login button

* feat(editor): SSO login button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system Upcoming Release Will be part of the upcoming release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants