Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix execution list item selection #5606

Merged
merged 28 commits into from
Mar 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
c0c36b6
fix(editor): Fix execution list item selection
cstuncsik Mar 3, 2023
811dd6a
fix(editor): Delete only selected executions
cstuncsik Mar 3, 2023
6db282c
fix(editor): Fix clear selection
cstuncsik Mar 3, 2023
c74e16c
fix(editor): Fix clear selection
cstuncsik Mar 3, 2023
b092793
fix(editor): Fix clear selection
cstuncsik Mar 3, 2023
5d7a652
Merge remote-tracking branch 'origin/master' into pay-101-unselect-a-…
cstuncsik Mar 6, 2023
f710769
Merge remote-tracking branch 'origin/master' into pay-101-unselect-a-…
cstuncsik Mar 7, 2023
6780c63
feat(editor): Add select all existing executions checkbox
cstuncsik Mar 7, 2023
9700903
fix(editor): Do not mark later loaded executions selected
cstuncsik Mar 7, 2023
cfe4785
test(editor): Add execution list unit test
cstuncsik Mar 9, 2023
fc9dcb9
fix(editor): Fix selection
cstuncsik Mar 9, 2023
920863c
test(editor): update execution selection test
cstuncsik Mar 9, 2023
985193f
Merge remote-tracking branch 'origin/master' into pay-101-unselect-a-…
cstuncsik Mar 10, 2023
50c1051
fix(editor): Handle UI state when there is no execution
cstuncsik Mar 10, 2023
e4e347e
fix(editor): Remove unnecessary logic
cstuncsik Mar 10, 2023
225bc8c
test(editor): Add more execution list unit tests and fake data genera…
cstuncsik Mar 10, 2023
80ee5ea
test(editor): Add more execution list unit tests
cstuncsik Mar 10, 2023
6238a43
test(editor): Simplifying test setup
cstuncsik Mar 13, 2023
fff0df6
Merge remote-tracking branch 'origin/master' into pay-101-unselect-a-…
cstuncsik Mar 13, 2023
4605be1
chore: update pnpm lock after resolving merge conflocts
cstuncsik Mar 13, 2023
0ce56df
chore: fix package version
cstuncsik Mar 13, 2023
669cabe
fix: Improved executions deletion to prevent crashing and fixed remov…
krynble Mar 14, 2023
f0605ba
fix: Add comment to clarify why change was needed
krynble Mar 14, 2023
984bd8e
fix: fix executions list bug when selecting all and changing filter
alexgrozav Mar 14, 2023
8594158
fix: fix execution lists running execution showing up on different wo…
alexgrozav Mar 14, 2023
16d7da6
Merge remote-tracking branch 'origin/master' into pay-101-unselect-a-…
cstuncsik Mar 16, 2023
a99ac01
fix(editor): Deleting an execution while all are selected
cstuncsik Mar 16, 2023
6bedc7f
fix(editor): Deleting an execution while all are selected
cstuncsik Mar 16, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/cli/src/executions/executions.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -541,6 +541,9 @@ export class ExecutionsService {
// delete executions by date, if user may access the underlying workflows
where.startedAt = LessThanOrEqual(deleteBefore);
Object.assign(where, requestFilters);
if (where.status) {
where.status = In(requestFiltersRaw!.status as string[]);
}
} else if (ids) {
// delete executions by IDs, if user may access the underlying workflows
where.id = In(ids);
Expand Down Expand Up @@ -568,6 +571,10 @@ export class ExecutionsService {
idsToDelete.map(async (id) => binaryDataManager.deleteBinaryDataByExecutionId(id)),
);

await Db.collections.Execution.delete(idsToDelete);
do {
// Delete in batches to avoid "SQLITE_ERROR: Expression tree is too large (maximum depth 1000)" error
const batch = idsToDelete.splice(0, 500);
await Db.collections.Execution.delete(batch);
} while (idsToDelete.length > 0);
}
}
1 change: 1 addition & 0 deletions packages/editor-ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@
"@faker-js/faker": "^7.6.0",
"@pinia/testing": "^0.0.14",
"@testing-library/jest-dom": "^5.16.5",
"@testing-library/user-event": "^14.4.3",
"@testing-library/vue": "^5.8.3",
"@types/dateformat": "^3.0.0",
"@types/express": "^4.17.6",
Expand Down
Loading