Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add events to enable onboarding checklist #5536

Merged
merged 28 commits into from
Feb 28, 2023
Merged

feat: Add events to enable onboarding checklist #5536

merged 28 commits into from
Feb 28, 2023

Conversation

mutdmour
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Feb 21, 2023
@mutdmour mutdmour changed the title feat: Add hook support for tracking feat: Add events to enable onboarding checklist Feb 28, 2023
name,
variant,
});

trackedDemoExp.value[name] = variant;
runExternalHook('posthog.featureFlagsUpdated', useWebhooksStore(), {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a new hook that was added but never used

@@ -328,7 +329,8 @@ export default mixins(showMessage, externalHooks).extend({
success: true,
});

this.$externalHooks().run('parameterInputFull.mappedData');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a new hook that was added but never used

Copy link
Member

@alexgrozav alexgrozav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thanks for taking care of this.

@mutdmour mutdmour merged commit 20c4919 into master Feb 28, 2023
@mutdmour mutdmour deleted the ado-323-1 branch February 28, 2023 10:44
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Feb 28, 2023
@janober
Copy link
Member

janober commented Mar 2, 2023

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Mar 2, 2023
sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
* feat: Add new event hooks

* fix: update event

* feat: Add more functionality for webhooks

* ⚡ Not sending onboarding checklist event from templates page

* 🔥 Removing quotes added by mistake

* ⚡ Added rest of events needed for onboarding checklist

* 💄 Hiding appcues checklist inside iframes

* 💄 Updating appcues selector

* fix: remove unnessary fix

* fix: fix schedule node

* refactor: bake events into segment store

* refactor: rename store

* refactor: use node keys

* refactor: remove unnessary

* chore: clean up store

* refactor: add key for event

* fix: allow tracking on template pages

* chore: remove comment

* fix: buidl

* refactor: block event if in iframe

* fix: fix tracking nodes

* refactor: track experiments once

* fix: ensure tracking works

* chore: remove comment

* fix: lint

* fix: lint

---------

Co-authored-by: Milorad Filipovic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants