Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Do not crash express app on unhandled rejected promises #5252

Merged
merged 1 commit into from
Jan 26, 2023
Merged

fix(core): Do not crash express app on unhandled rejected promises #5252

merged 1 commit into from
Jan 26, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Jan 25, 2023

Ticket: ENG-42
Fixes: #5249

Joffcom
Joffcom approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@Joffcom Joffcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tested ok for me using the recent API issue as a trigger.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jan 25, 2023
@netroy netroy merged commit 7e229a3 into master Jan 26, 2023
@netroy netroy deleted the ENG-42-stop-express-rejected-promise-crashes branch January 26, 2023 11:10
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Jan 26, 2023
@netroy netroy mentioned this pull request Jan 26, 2023
Closed
@janober
Copy link
Member

janober commented Jan 27, 2023

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joffcom Joffcom Joffcom approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team skip-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

N8N - API api/v1/executions => application crashes
3 participants
@netroy @janober @Joffcom