Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Extension being too eager and making calls when it shouldn't #5232

Merged
merged 1 commit into from
Jan 24, 2023
Merged

fix: Extension being too eager and making calls when it shouldn't #5232

merged 1 commit into from
Jan 24, 2023

Conversation

valya
Copy link
Contributor

@valya valya commented Jan 23, 2023

No description provided.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jan 23, 2023
ivov
ivov approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passing and reported case {{ Math.floor($json['arr'].length + 1) }} works as expected.

@valya valya merged commit 09bdd96 into master Jan 24, 2023
@valya valya deleted the n8n-6026-using-mathfloor-with-jsonxlength-doesnt branch January 24, 2023 12:04
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Jan 24, 2023
@Joffcom Joffcom mentioned this pull request Jan 24, 2023
Closed
MiloradFilipovic added a commit that referenced this pull request Jan 25, 2023
@MiloradFilipovic
Merge branch 'master' into ado-6-ndv-simplify-credentials
54df62c 
* master:
  fix(editor): Fix save modal appearing after duplicating a workflow (#5247)
  feat(editor): Adjust Google sign-in button to adhere to the guidelines (#5248)
  fix(HelpScout Node): Fix tag search not working when getting all conversations (#5239)
  fix(editor): Do not request workflow data twice when opening a workflow (#5246)
  fix(editor): Fix the element-ui imports in SettingsLdapView (no-changelog) (#5245)
  fix(core): Handle missing binary metadata in download urls (#5242)
  ci: Simplify DB truncate in tests (no-changelog) (#5243)
  feat(core): Add LDAP support (#3835)
  fix(core): Upsert credentials and workflows in the import:* commands (#5231)
  feat(Jira Software Node): Use resource locator component (#5090)
  ci: Publish n8n docker images to GHCR (#5213)
  fix(Google Drive Node): Use the correct mimetype on converted downloads (#5240)
  fix(editor): Prevent workflow execution list infinite no network error (#5230)
  fix: Extension being too eager and making calls when it shouldn't (#5232)
  feat(Send Email Node): Overhaul
  refactor(core): Add support for implicit schema in postgres migrations (#5233)

# Conflicts:
#	packages/editor-ui/src/components/CredentialEdit/CredentialConfig.vue
@janober
Copy link
Member

janober commented Jan 27, 2023

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivov ivov ivov approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valya @janober @ivov