docs: Update the contribution guidelines (no-changelog) #5165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
svzi
changed the title
Joffcom
approved these changes
Jan 19, 2023
Joffcom
changed the title
|
Hey @svzi, Thanks for the PR, This has now been merged 🎉 |
n8n-assistant
bot
added
the
Upcoming Release
MiloradFilipovic
added a commit
that referenced
this pull request
Jan 19, 2023
* master: docs: Update the contribution guidelines (no-changelog) (#5165) fix(HTTP Request Node): Bug - node requires string instead of json fix(GitLab Node): Update credential test endpoint (#5166) fix(editor): Allow special chars in node selector completion (#5196) test: Add tests for pinning data (#5157) fix(core): Fix migration (no-changelog) (#5186) fix(HTTP Request Node): Response format to text is ignored for JSON responses fix(Gmail Trigger Node): Filter by labels not working (#5173) feat(Item Lists Node): Table tranformation 📚 Update CHANGELOG.md and main package.json to 0.211.2 🔖 Release [email protected] ⬆️ Set [email protected] on n8n 🔖 Release [email protected] fix(core): Restore community nodes installation (#5180) feat: (Google Sheets Trigger Node): Trigger for Google Sheets test: Add e2e tests for PRs (#5176)
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst setting up my mac for development purposes, I've stumbled upon a few difficulties in the
CONTRIBUTING.mgguide. So I thought to make some changes to the requirements section. For example the NodeJS and pnpn versions that are defined in theenginessection of thepackage.json. I've also updated some other parts and re-sorted two section. This way a new contributor should be able to follow the guide step by step and getting the understanding of what he does. That was missing during my setup. I hope it's now more clear to new developer, joining the project.If you want me to change or revert something, please let me know.
Best,
Sven