Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Fixes event msg confirmations if no subscribers present #5118

Merged
merged 7 commits into from
Jan 11, 2023

Conversation

flipswitchingmonkey
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@flipswitchingmonkey flipswitchingmonkey marked this pull request as ready for review January 10, 2023 09:35
@flipswitchingmonkey flipswitchingmonkey changed the title fix(cli): Fixes event msg confirmations if no subscribers present fix(core): Fixes event msg confirmations if no subscribers present Jan 10, 2023
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jan 10, 2023
krynble
krynble previously approved these changes Jan 11, 2023
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; left just a comment. If you add information to PR description then feel free to merge.

# Conflicts:
#	packages/editor-ui/src/components/ExecutionsList.vue
@flipswitchingmonkey flipswitchingmonkey merged commit 62d06b1 into master Jan 11, 2023
@flipswitchingmonkey flipswitchingmonkey deleted the ENG-24-fix-evenbus-logfile-reading branch January 11, 2023 13:09
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Jan 11, 2023
MiloradFilipovic added a commit that referenced this pull request Jan 11, 2023
* master:
  fix(core): Fixes event msg confirmations if no subscribers present (#5118)
  refactor(core): Diverge syntax error handling in expressions (#5124)
  fix(editor): Recover from unsaved finished execution  (#5121)
  feat(editor): Executions page (#4997)
  docs: Update the contribution guidelines for node creation (#5120)
  feat: Expression extension framework (#4372)
  fix(editor): Fixes event bus test (#5119)
  refactor(TelegramTrigger Node, ShopifyTrigger Node): Standardize node triggers actions (#5117)
  feat(editor): Remove prevent-ndv-auto-open feature flag (#5114)
  refactor: On workflow deletion, cascade delete all entities associated with it (#5102)

# Conflicts:
#	packages/editor-ui/src/Interface.ts
@janober
Copy link
Member

janober commented Jan 13, 2023

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants