Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Add more overloads for string-type node parameters (no-changelog) #5101

Merged
merged 2 commits into from
Jan 6, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Jan 6, 2023

continued from #4797

@netroy netroy requested a review from ivov January 6, 2023 13:18
@netroy netroy changed the title refactor(core): Add more overloads for string-type node parameter (no-changelog) refactor(core): Add more overloads for string-type node parameters (no-changelog) Jan 6, 2023
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request labels Jan 6, 2023
ivov
ivov previously approved these changes Jan 6, 2023
Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Partly related, I found binaryPropertyOutput in Compression.node.ts

@netroy
Copy link
Member Author

netroy commented Jan 6, 2023

LGTM. Partly related, I found binaryPropertyOutput in Compression.node.ts

updated

@netroy netroy merged commit 1acc7fe into master Jan 6, 2023
@netroy netroy deleted the more-string-props branch January 6, 2023 14:09
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Jan 6, 2023
MiloradFilipovic added a commit that referenced this pull request Jan 9, 2023
* master: (53 commits)
  fix: Remove anonymous ID from tracking calls (#5099)
  refactor(core): Add more overloads for string-type node parameters (no-changelog) (#5101)
  fix(Read Binary File Node): Do not crash the execution when the source file does not exist (#5100)
  fix: Stop OOM crashes in Execution Data pruning (#5095)
  feat(editor): Introduce proxy completions to expressions (#5075)
  fix(Google Sheets Node): Fix for auto-range detection
  📚 Update CHANGELOG.md and main package.json to 0.210.1
  🔖 Release [email protected]
  ⬆️ Set [email protected] and [email protected] on n8n
  🔖 Release [email protected]
  ⬆️ Set [email protected] on n8n-editor-ui
  🔖 Release [email protected]
  🔖 Release [email protected]
  fix: Pass in the correct server reference to external hooks (no-changelog) (#5094)
  fix(Google Sheets Node): Append or Update fails for numeric values
  feat: Add user management invite links without SMTP set up (#5084)
  fix: Remove annonymous ID (no-changelog) (#5093)
  📚 Update CHANGELOG.md and main package.json to 0.210.0
  🔖 Release [email protected]
  ⬆️ Set [email protected], [email protected], [email protected] and [email protected] on n8n
  ...

# Conflicts:
#	packages/editor-ui/src/components/CredentialEdit/CredentialEdit.vue
@janober
Copy link
Member

janober commented Jan 9, 2023

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants