fix(editor): Usage and plans page on Desktop #5045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
ivov
approved these changes
Dec 28, 2022
| @@ -53,34 +53,36 @@ const onLicenseActivation = async () => { | |||
| }; | |||
|
|
|||
| onMounted(async () => { | |||
| usageStore.setLoading(true); | |||
| if (route.query.key) { | |||
| if (!usageStore.isDesktop) { | |||
There was a problem hiding this comment.
Nit - inverting the check and returning early would prevent the nesting and shorten the diff.
|
|
||
| const openPricingPage = () => { | ||
| sendUsageTelemetry('desktop_view_plans'); | ||
| window.open('https://n8n.io/pricing', '_blank'); |
There was a problem hiding this comment.
Ideally the URL in a constant.
|
Thanks @ivov , agree but I have to leave now. If you have time now please update otherwise I'll just merge |
n8n-assistant
bot
added
the
Upcoming Release
|
Got released with |
MiloradFilipovic
added a commit
that referenced
this pull request
Dec 29, 2022
* master: ci: Fix linting on builds (no-changelog) (#5062) refactor: Lint for no interpolation in regular string (#5060) (no-changelog) ci: Fix lint for build (no-changelog) (#5059) perf: Prevent oclif from loading ts-node and typescript (#5047) (no-changelog) fix(editor): Make node title non-editable in executions view (#5046) refactor: Lint for no unneeded backticks (#5057) (no-changelog) fix(core): Fix full manual execution for error trigger as starter of 2+ node workflow (#5055) fix(editor): Support tabbing away from inline expression editor (#5056) refactor(editor): Usage and plans page on Desktop (#5051) 📚 Update CHANGELOG.md and main package.json to 0.209.4 🔖 Release [email protected] ⬆️ Set [email protected] on n8n 🔖 Release [email protected] fix(editor): Usage and plans page on Desktop (#5045) feat(editor): Switch to expression on `=` input (#5044) fix(editor): Fix trigger node type identification on add to canvas (#5043)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue / Community forum post (link here to close automatically):