Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Ensure full tree on expression editor parse #5027

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

@netroy netroy self-requested a review December 23, 2022 15:05
@@ -1,9 +1,10 @@
import mixins from 'vue-typed-mixins';
import { mapStores } from 'pinia';
import { syntaxTree } from '@codemirror/language';
import { ensureSyntaxTree, syntaxTree } from '@codemirror/language';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntaxTree is unused. but I'm gonna clean that up in a separate linting PR.

Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@netroy netroy merged commit 47854eb into master Dec 23, 2022
@netroy netroy deleted the ado-146-full-tree branch December 23, 2022 15:13
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Dec 23, 2022
@janober
Copy link
Member

janober commented Dec 23, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants