Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Move Binary Data Node): Stringify objects before encoding them in MoveBinaryData #4882

Merged
merged 4 commits into from
Dec 11, 2022

Conversation

netroy
Copy link
Member

@netroy netroy commented Dec 9, 2022

also improve the way we show binary JSON data in the UI by

  1. showing file size and file type, and adding a view option for text and json files
    image

  2. Rendering JSON binary files with formatting
    image

@netroy netroy requested review from that-one-tom and removed request for that-one-tom December 9, 2022 14:34
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request ui Enhancement in /editor-ui or /design-system labels Dec 9, 2022
@maspio maspio self-requested a review December 9, 2022 17:24
@netroy netroy merged commit 3b969d2 into master Dec 11, 2022
@netroy netroy deleted the NODE-117-json-data-ux-improvements branch December 11, 2022 13:10
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Dec 11, 2022
MiloradFilipovic added a commit that referenced this pull request Dec 12, 2022
* master:
  fix(editor): Avoid adding manual trigger node when webhook node is added (#4887)
  ci: Add libc6-compat to nightly docker builds (no-changelog) (#4885)
  fix(Move Binary Data Node): Stringify objects before encoding them in MoveBinaryData (#4882)
  ci: Upgrade pnpm and turborepo (no-changelog) (#4878)
  fix(editor): Fix for broken tab navigation (#4881)
  feat(editor): Add undo/redo support for canvas actions (#4787)
  fix(Split In Batches Node): Fix issue with pairedItem (#4873)
  fix: Update duplicate action (#4858)

# Conflicts:
#	packages/editor-ui/src/Interface.ts
#	packages/editor-ui/src/mixins/history.ts
#	packages/editor-ui/src/views/NodeView.vue
@janober
Copy link
Member

janober commented Dec 12, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants