Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Fix credential sharing issues handler when no matching id or name #4879

Merged
merged 3 commits into from
Dec 12, 2022
Merged

fix(editor): Fix credential sharing issues handler when no matching id or name #4879

merged 3 commits into from
Dec 12, 2022

Conversation

alexgrozav
Copy link
Member

@alexgrozav alexgrozav commented Dec 9, 2022 •
edited
Loading

image

@alexgrozav alexgrozav changed the title fix: fix credential sharing issues handler when no matching id or name fix(editor-ui): Fix credential sharing issues handler when no matching id or name Dec 9, 2022
@alexgrozav alexgrozav changed the title fix(editor-ui): Fix credential sharing issues handler when no matching id or name fix(editor): Fix credential sharing issues handler when no matching id or name Dec 9, 2022
@alexgrozav alexgrozav added ui Enhancement in /editor-ui or /design-system n8n team Authored by the n8n team labels Dec 9, 2022
@alexgrozav alexgrozav merged commit 1cce8ea into master Dec 12, 2022
@alexgrozav alexgrozav deleted the n8n-5657-credential-display-value-for-instance-owner branch December 12, 2022 12:46
@alexgrozav alexgrozav added the Upcoming Release Will be part of the upcoming release label Dec 12, 2022
MiloradFilipovic added a commit that referenced this pull request Dec 12, 2022
@MiloradFilipovic
Merge branch 'master' into ADO-32-e2e-undo
a29dd6e 
* master:
  feat: Add sharing permissions info for workflow sharees (#4892)
  fix(editor): Fix credential sharing issues handler when no matching id or name (#4879)
  fix: Update translation for sharing toast (no-changelog) (#4893)
  fix: Remove delete sharee prompt except when deleting last cred accessor (no-changelog) (#4894)
  fix: Remove foreign credentials when copying nodes or duplicating workflow (#4880)
  feat: Update credential test error message for sharees (#4864)
  feat: Handle sharing features when user skips owner setup (#4850)
  fix(editor): Schema view shows checkbox in case of empty data (#4889)
  fix(core): Remove `nodeGetter` checks (#4883)
@janober
Copy link
Member

janober commented Dec 12, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krynble krynble krynble approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexgrozav @janober @krynble