Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Local File Trigger Node): Fix issue that causes a crash if the ignore field is empty (#4824) #4825

Merged
merged 1 commit into from
Dec 6, 2022
Merged

fix(Local File Trigger Node): Fix issue that causes a crash if the ignore field is empty (#4824) #4825

merged 1 commit into from
Dec 6, 2022

Conversation

marzn
Copy link
Contributor

@marzn marzn commented Dec 5, 2022 •
edited by Joffcom
Loading

Fixes #4824

@CLAassistant
Copy link

CLAassistant commented Dec 5, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@marzn marzn mentioned this pull request Dec 5, 2022
Closed
@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request labels Dec 5, 2022
@Joffcom
Copy link
Member

Joffcom commented Dec 6, 2022

Hey @marzn

Thanks for the PR I am going to take a look at this today and hopefully get it merged in.

@Joffcom
Copy link
Member

Joffcom commented Dec 6, 2022

Hey @marzn,

It looks good to me and it works, This is a really nice find. Thanks again for taking the time to submit this PR 🙌🏻

@Joffcom Joffcom changed the title fix(LocalFileTrigger): empty string as value for chokidar watch watchOptions.ignored (#4824) fix(LocalFileTrigger): fix issue that causes a crash if the ignore field is empty (#4824) Dec 6, 2022
@Joffcom Joffcom changed the title fix(LocalFileTrigger): fix issue that causes a crash if the ignore field is empty (#4824) fix(Local File Trigger Node): fix issue that causes a crash if the ignore field is empty (#4824) Dec 6, 2022
@Joffcom Joffcom changed the title fix(Local File Trigger Node): fix issue that causes a crash if the ignore field is empty (#4824) fix(Local File Trigger Node): Fix issue that causes a crash if the ignore field is empty (#4824) Dec 6, 2022
@Joffcom Joffcom merged commit c311424 into n8n-io:master Dec 6, 2022
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Dec 6, 2022
MiloradFilipovic added a commit that referenced this pull request Dec 6, 2022
@MiloradFilipovic
Merge branch 'master' into feature/undo-redo
69313f1 
* master:
  fix: Handle error when workflow does not exist or is inaccessible (#4831)
  feat(editor): Schema view (#4615)
  fix: Enable source-maps on WorkflowRunnerProcess in `own` mode (#4832)
  ci: Fix linting on master (no-changelog) (#4830)
  feat: Add message for readonly nodes. Improve foreign credentials handling (#4759)
  feat(KoBoToolbox Node): Add support for Media file API (#4578)
  fix(Local File Trigger Node): Fix issue that causes a crash if the ignore field is empty (#4824) (#4825)
  refactor: Codex updates for XML and HtmlExtract Nodes (#4801)
  refactor: Reactivate workflow locking (#4770)

# Conflicts:
#	packages/editor-ui/src/Interface.ts
@janober
Copy link
Member

janober commented Dec 7, 2022

Got released with [email protected]

1 similar comment
@janober
Copy link
Member

janober commented Dec 7, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joffcom Joffcom Joffcom approved these changes

Assignees
No one assigned
Labels
community Authored by a community member node/improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

n8n crashes on start if LocalFileTrigger option ignored is an empty string
4 participants
@marzn @CLAassistant @Joffcom @janober