feat(Ldap Node): Add LDAP node #4783

Joffcom · 2022-12-01T13:13:30Z

No description provided.

github-actions · 2023-04-04T15:53:51Z

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

If fixing bug, added test to cover scenario.
If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

Added workflow tests for nodes if possible.

Files matching packages/nodes-base/package.json:

Avoided adding dependencies for nodes if not absolutely necessary.

Make sure to check off this list before asking for review.

codecov · 2023-04-04T16:08:27Z

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (2a20a19) 27.66% compared to head (9e1258f) 27.63%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4783      +/-   ##
==========================================
- Coverage   27.66%   27.63%   -0.03%     
==========================================
  Files        2938     2942       +4     
  Lines      180015   180212     +197     
  Branches    19543    19578      +35     
==========================================
+ Hits        49805    49810       +5     
- Misses     129479   129669     +190     
- Partials      731      733       +2

Impacted Files	Coverage Δ
...ackages/nodes-base/credentials/Ldap.credentials.ts	`0.00% <0.00%> (ø)`
packages/nodes-base/nodes/Ldap/Helpers.ts	`0.00% <0.00%> (ø)`
packages/nodes-base/nodes/Ldap/Ldap.node.ts	`0.00% <0.00%> (ø)`
packages/nodes-base/nodes/Ldap/LdapDescription.ts	`0.00% <0.00%> (ø)`

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

packages/nodes-base/nodes/Ldap/Ldap.node.ts

Joffcom · 2023-05-09T16:09:47Z

@madgbec not sure I understand, what are you trying to do?

Joffcom · 2023-05-10T04:04:46Z

Are you getting any error messages and which ldap server implementation are you using?

github-actions · 2023-05-15T16:38:31Z

✅ All Cypress E2E specs passed

* allow execution on node 19,20,22 * fix(ERPNext Node): Fix issue with credential test and add frappe cloud url (n8n-io#6283) * fix(editor): UI copy fix for Date & Time node (no-changelog) (n8n-io#6291) * whether -> when * lint fix --------- Co-authored-by: Jonathan Bennetts <[email protected]> * feat(RabbitMQ Node): Add mode for acknowledging and deleting from queue later in workflow (n8n-io#6225) * Add later in workflow mode * Add new operation * Acknowledge message in next node * Add response and emit for responsePromiseHook * Remove double success message, close channel correctly * Answser messages correctly * Remove option from delete operation * move operation name to camelCase * Fix versioning * To remove: add action item in v1 * Add notice for delete from queue * Correctly only execute only the delete operation * Refactor delete from queue operator and add return last items --------- Co-authored-by: Marcus <[email protected]> * feat: Add dangerouslyUseHTMLString where needed (no-changelog) (n8n-io#6292) feat: add dangerouslyUseHTMLString where needed (no-changelog) * fix(Wekan Node): Handle response correctly (n8n-io#6296) Fix bug when response wasn't array * Added procfile * Added procfile * redployed * redployed * redployed * redployed * redployed * redployed * dont start * redployed * redployed * update version * redployed * redployed * redployed * redployed * Revert "update version" This reverts commit c249585. * add heroku stack version * delete * add app.json setting heroku build stack * update * update vite * update mem * update PORT * redployed * fix(core): Optimize SharedWorkflow queries (n8n-io#6297) * optimize SharedWorkflow queries * fix int to string ids * fix(Strapi Node): Strapi credentials notice (n8n-io#6289) * fix(SSH Node): Private key field as password and credential test (n8n-io#6298) * fix: Prevent removing manual executions when setting says to save (n8n-io#6300) * fix: Initialize license in queue mode correctly (n8n-io#6301) * feat(Ldap Node): Add LDAP node (n8n-io#4783) * feat(LoneScale Node): Add LoneScale node and Trigger node (n8n-io#5146) * feat: Add SSO SAML metadataUrl support and various improvements (n8n-io#6139) * feat: add various sso improvements * fix: remove test button assertion * fix: fix type imports * test: attempt fixing unit tests * fix: changed to using useToast for error toasts * Minor copy tweaks and swapped buttons position. * fix locale ref * align error with UI wording * simplify saving ux * fix pretty * fix: update saml sso setting saving * fix: undo try/catch changes when saving saml config * metadata url tab selected at first * chore: fix linting issue * test: fix activation checkbox test --------- Co-authored-by: Giulio Andreini <[email protected]> Co-authored-by: Michael Auerswald <[email protected]> Co-authored-by: Romain Minaud <[email protected]> * fix(editor): Fix canvas loading when page gets restored from bfcache (n8n-io#6304) * fix(editor): Fix canvas loading when page gets restored from bfcache * Lint fix * fix(editor): Link to log streaming doc from log streaming (no-changelog) (n8n-io#6303) link to log streaming doc from log streaming --------- Co-authored-by: Eyal Fishler <[email protected]> Co-authored-by: Jon <[email protected]> Co-authored-by: Deborah <[email protected]> Co-authored-by: agobrech <[email protected]> Co-authored-by: Marcus <[email protected]> Co-authored-by: Alex Grozav <[email protected]> Co-authored-by: Omri Attoun <[email protected]> Co-authored-by: Michael Auerswald <[email protected]> Co-authored-by: Michael Kret <[email protected]> Co-authored-by: Omar Ajoue <[email protected]> Co-authored-by: Yann ALEMAN <[email protected]> Co-authored-by: Giulio Andreini <[email protected]> Co-authored-by: Romain Minaud <[email protected]> Co-authored-by: OlegIvaniv <[email protected]>

janober · 2023-05-25T11:41:02Z

Got released with [email protected]

Joffcom added 12 commits November 28, 2022 11:21

Initial commit based on the n8n-nodes-ldap repo, Thanks Pemontto

4363794

small updates

608a8e2

improvements

a27a29f

Merge branch 'master' of github.com:n8n-io/n8n into n8n-5432

873761a

Added quick credential test

e385029

started looking into AD attribute values

8431280

Merge branch 'master' of github.com:n8n-io/n8n into n8n-5432

59f8a6d

Updated credential fields and fixed AD binary options

8ed7d55

Fixed search attributes

483680b

Small tweak to DN

a343197

Merge branch 'master' of github.com:n8n-io/n8n into n8n-5432

60a158f

Quick lint fix

bf52204

n8n-assistant bot added n8n team Authored by the n8n team node/new Creation of an entirely new node labels Dec 1, 2022

Joffcom changed the title ~~feat(LDAP Node): Add LDAP node~~ feat(Ldap Node): Add LDAP node Dec 1, 2022

Joffcom added 14 commits December 5, 2022 10:15

Merge branch 'master' of github.com:n8n-io/n8n into n8n-5432

8c04cf5

Merge branch 'master' of github.com:n8n-io/n8n into n8n-5432

3d3ed7f

Merge branch 'master' of github.com:n8n-io/n8n into n8n-5432

ee50b24

Tweaked UI from initial design review

359ab71

Merge branch 'master' of github.com:n8n-io/n8n into n8n-5432

c1952dc

Made search a bit more user friendly

d8b380a

Merge branch 'master' of github.com:n8n-io/n8n into n8n-5432

f57ba62

fixed issues from field rename

e8ad373

Idea for loading attributes

a04b790

Merge branch 'master' of github.com:n8n-io/n8n into n8n-5432

994b6a1

removed comments

bf86700

Merge branch 'master' of github.com:n8n-io/n8n into n8n-5432

7f924b1

Lint fixes

9ad6a34

Merge branch 'master' of github.com:n8n-io/n8n into n8n-5432

f815257

Joffcom added 9 commits April 13, 2023 15:07

Update wording from design review

d47a5b1

Merge branch 'master' of github.com:n8n-io/n8n into n8n-5432

10f88f7

Merge branch 'master' of github.com:n8n-io/n8n into n8n-5432

35fe436

updated dn descriptions

21b9104

Merge branch 'master' of github.com:n8n-io/n8n into n8n-5432

d6f1592

Merge branch 'master' of github.com:n8n-io/n8n into n8n-5432

e73ecb3

update descriptions and actions

c79a19d

pnpm lock

e732a15

Merge branch 'master' of github.com:n8n-io/n8n into n8n-5432

d535212

Joffcom marked this pull request as ready for review May 9, 2023 08:25

maspio reviewed May 9, 2023

View reviewed changes

packages/nodes-base/nodes/Ldap/Ldap.node.ts Outdated Show resolved Hide resolved

Joffcom and others added 6 commits May 10, 2023 13:21

Merge branch 'master' of github.com:n8n-io/n8n into n8n-5432

03f5dd8

updates from review

dae6cc8

Update from review

80e6379

Merge branch 'master' of github.com:n8n-io/n8n into n8n-5432

f83c322

Removed surprise log message

4232269

removed unused imports and comments

9e1258f

maspio approved these changes May 15, 2023

View reviewed changes

Joffcom merged commit ec393bc into master May 23, 2023

Joffcom deleted the n8n-5432 branch May 23, 2023 11:39

janober added the Released label May 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(Ldap Node): Add LDAP node #4783

feat(Ldap Node): Add LDAP node #4783

Joffcom commented Dec 1, 2022

github-actions bot commented Apr 4, 2023 •

edited

Loading

codecov bot commented Apr 4, 2023 •

edited

Loading

Joffcom commented May 9, 2023

Joffcom commented May 10, 2023

github-actions bot commented May 15, 2023

janober commented May 25, 2023

feat(Ldap Node): Add LDAP node #4783

feat(Ldap Node): Add LDAP node #4783

Conversation

Joffcom commented Dec 1, 2022

github-actions bot commented Apr 4, 2023 • edited Loading

codecov bot commented Apr 4, 2023 • edited Loading

Codecov Report

Joffcom commented May 9, 2023

Joffcom commented May 10, 2023

github-actions bot commented May 15, 2023

janober commented May 25, 2023

github-actions bot commented Apr 4, 2023 •

edited

Loading

codecov bot commented Apr 4, 2023 •

edited

Loading