Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Lazy load nodes for credentials testing #4760

Merged
merged 4 commits into from
Nov 30, 2022
Merged

fix: Lazy load nodes for credentials testing #4760

merged 4 commits into from
Nov 30, 2022

Conversation

netroy
Copy link
Member

@netroy netroy commented Nov 29, 2022 •
edited
Loading

This also fixed the issue of the frontend not passing in nodeToTestWith to the backend

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request ui Enhancement in /editor-ui or /design-system labels Nov 29, 2022
Joffcom
Joffcom previously approved these changes Nov 29, 2022
View reviewed changes
@netroy netroy changed the title fix: Lazy load nodes for credentials testing fix: Lazy load nodes for credentials testing N8N-5776 Nov 29, 2022
@netroy netroy changed the title fix: Lazy load nodes for credentials testing N8N-5776 fix: Lazy load nodes for credentials testing Nov 29, 2022
@netroy netroy force-pushed the fix-credentials-testing branch 2 times, most recently from cb54739 to a25cd6f Compare November 29, 2022 15:00
@netroy netroy requested a review from Joffcom November 29, 2022 16:28
Joffcom
Joffcom approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@Joffcom Joffcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good.

@netroy netroy merged commit 0a7a2f3 into master Nov 30, 2022
@netroy netroy deleted the fix-credentials-testing branch November 30, 2022 09:28
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Nov 30, 2022
MiloradFilipovic added a commit that referenced this pull request Nov 30, 2022
@MiloradFilipovic
Merge branch 'master' into feature/undo-redo
fda6e8f 
* master:
  fix: Lazy load nodes for credentials testing (#4760)
  fix(core): Fix `$items().length` in Execute Once mode (#4755)
  feat(Google Calendar Node): Use resource locator component for calendar parameters (#4410)
  fix: Change the currentUserHasAccess flag behavior (no-changelog) (#4763)
@netroy netroy mentioned this pull request Dec 1, 2022
Closed
@janober
Copy link
Member

janober commented Dec 2, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joffcom Joffcom Joffcom approved these changes

@michael-radency michael-radency Awaiting requested review from michael-radency

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@netroy @janober @Joffcom