refactor(core): Reduce memory usage in the Webhook node #4640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
netroy
force-pushed
the
N8N-4571-webhook-memory-optimization
branch
4 times, most recently
from
e706a2d
to
3eaeb0e
Compare
netroy
force-pushed
the
N8N-4571-webhook-memory-optimization
branch
from
3eaeb0e
to
46e8ef4
Compare
janober
added
Upcoming Release
MiloradFilipovic
added a commit
that referenced
this pull request
Nov 25, 2022
* master: refactor: Improve typings for element-ui imports (no-changelog) (#4678) fix(core): Mark binary data to be deleted when pruning executions (#4713) test: Add e2e tests for workflow/credential migrations when enabling UM (#4719) ci: Setup cypress tasks for resetting DB, and setting up an owner (#4717) fix: Fix Windows development environments (no-changelog) (#4720) refactor(core): Reduce memory usage in the Webhook node (#4640) 📚 Update CHANGELOG.md and main package.json to 0.204.0 🔖 Release [email protected] ⬆️ Set [email protected], [email protected], [email protected] and [email protected] on n8n 🔖 Release [email protected] ⬆️ Set [email protected] and [email protected] on n8n-editor-ui 🔖 Release [email protected] 🔖 Release [email protected] ⬆️ Set [email protected] and [email protected] on n8n-nodes-base 🔖 Release [email protected] ⬆️ Set [email protected] and [email protected] on n8n-node-dev 🔖 Release [email protected] ⬆️ Set [email protected] on n8n-core 🔖 Release [email protected] fix: Apply SpecialNodeParameters to the types generated for the frontend (no-changelog) (#4715)
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the Webhook node and the BinaryDataManager to avoid loading the binary payload even in memory, preventing any OOM crashes on large binary uploads
TODO: