ci: Ensure that eslint runs on all frontend code (no-changelog)

[netroy]

also,

• remove tslint from design-system
• setup prettier for design-system

[linear]

N8N-3405

[ivov]

1. Let's remove /design-system/tslint.json?

2. design-system/.editorconfig still needed?

3. Should we lint the contents of .storybook?

4. prettier **/**.{ts,vue} --write Let's format all others as well? css, scss, js, md, mdx

5. Button.stories.ts still contains a TSLint exception.

6. These only trigger one issue each. Let's fix and remove from the list?

• @typescript-eslint/ban-ts-comment
• @typescript-eslint/restrict-template-expressions
• @typescript-eslint/no-unused-vars

7. @typescript-eslint/member-delimiter-style triggers no issues. Let's remove from the list.

8. @typescript-eslint/naming-convention triggers 220 issues. design-system might need its own options for this rule.

9. import/no-extraneous-dependencies triggers 80+ issues but seemingly easy to fix by moving a handful of deps to their right categories. Please disregard if time-consuming.

10. For any remaining rules that are off, let's set to warn?

[netroy]

1. Let's remove /design-system/tslint.json?

✅

2. `design-system/.editorconfig` still needed?

✅

3. Should we lint the contents of `.storybook`?

✅

4. `prettier **/**.{ts,vue} --write` Let's format all others as well? css, scss, js, md, mdx

✅ , but skipped .md files

5. `Button.stories.ts` still contains a TSLint exception.

✅

6. These only trigger one issue each. Let's fix and remove from the list?
* `@typescript-eslint/ban-ts-comment`
* `@typescript-eslint/restrict-template-expressions`
* `@typescript-eslint/no-unused-vars`

✅

7. `@typescript-eslint/member-delimiter-style` triggers no issues. Let's remove from the list.

✅

8. `@typescript-eslint/naming-convention` triggers 220 issues. design-system might need its own options for this rule.

✅

9. `import/no-extraneous-dependencies` triggers 80+ issues but seemingly easy to fix by moving a handful of deps to their right categories. Please disregard if time-consuming.

✅

10. For any remaining rules that are `off`, let's set to `warn`?

✅ , but left it still off for two rules that I plan to remove in another PR.

[alexgrozav]

Took a look as well and looks good to me, but @ivov seems to have gone through a more in-depth review on it. Will let you guys continue on this.

[ivov]

Running vitest run --coverage and then formatting slows Prettier down to a crawl. We should add coverage to .prettierignore.

[netroy]

Running vitest run --coverage and then formatting slows Prettier down to a crawl. We should add coverage to .prettierignore.

Done.

Unfortunately .prettierignore still doesn't merge rules like .gitignore, .npmignore, and .dockerignore do 😞 .

[netroy]

a newly added file on master was failing on linting. fixed it.
@ivov can you please approve again?

[janober]

Got released with [email protected]