Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix for execution retry dropdown not closing #4575

Merged
merged 5 commits into from
Nov 14, 2022

Conversation

MiloradFilipovic
Copy link
Contributor

This also fixes two other problems spotted along the way:

  • Wrong retry option i18n label reference
  • Execution preview not interactible in the upper part of the iframe

@MiloradFilipovic MiloradFilipovic self-assigned this Nov 10, 2022
@linear
Copy link

linear bot commented Nov 10, 2022

N8N-5308

* master:
  🔖 Release [email protected]
  ⬆️ Set [email protected], [email protected], [email protected] and [email protected] on n8n
  🔖 Release [email protected]
  ⬆️ Set [email protected] and [email protected] on n8n-editor-ui
  🔖 Release [email protected]
  🔖 Release [email protected]
  ⬆️ Set [email protected] and [email protected] on n8n-nodes-base
  🔖 Release [email protected]
  ⬆️ Set [email protected] and [email protected] on n8n-node-dev
  🔖 Release [email protected]
  ⬆️ Set [email protected] on n8n-core
  🔖 Release [email protected]
  refactor(editor): Reintroduce `item` and `items` to `CodeNodeEditor` (#4553)
  fix(core): Streamline multiple pinned triggers behavior (#4569)
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 10, 2022
* master:
  📚 Update CHANGELOG.md and main package.json to 0.202.0
  📚 Update CHANGELOG.md and main package.json to 0.202.0
ivov
ivov previously approved these changes Nov 11, 2022
Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working. Only minor comments.

@MiloradFilipovic MiloradFilipovic merged commit e0ec5a6 into master Nov 14, 2022
@MiloradFilipovic MiloradFilipovic deleted the N8N-5308-execution-retry-popup-fix branch November 14, 2022 08:35
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Nov 14, 2022
MiloradFilipovic added a commit that referenced this pull request Nov 14, 2022
* master:
  refactor: Remove Vetur config (no-changelog) (#4581)
  fix(editor): Fix expression editor variable selector filter (#4590)
  fix(editor): Curb direct item access linting (#4591)
  fix(editor): Skip optional chaining operators in Code Node editor linting (#4592)
  fix(editor): Fix for execution retry dropdown not closing (#4575)
  fix: Fix inferred type of X cannot be named error after pnpm update (no-changelog) (#4585)
@janober
Copy link
Member

janober commented Nov 17, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants