Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(editor): Add support for notice credentials properties #4557

Merged
merged 1 commit into from
Nov 9, 2022
Merged

feat(editor): Add support for notice credentials properties #4557

merged 1 commit into from
Nov 9, 2022

Conversation

MiloradFilipovic
Copy link
Contributor

In order to test this, add a property with notice type to credentials definition of any node (for example here).
An example of notice param:

{
  displayName:
  'On 30 November, 2022 Hubspot will remove API key support. You will have to connect to HubSpot using other auth method. <a href="https://www.hubspot.com/" target="_blank">More details (HubSpot.com)</a>',
  name: 'notice',
  type: 'notice',
  default: '',
},

@MiloradFilipovic MiloradFilipovic self-assigned this Nov 9, 2022
@linear
Copy link

linear bot commented Nov 9, 2022

N8N-5393

@MiloradFilipovic MiloradFilipovic changed the title ✨ Added notice parameter support for credentials. (feat)editor: Add support for notice credentials properties Nov 9, 2022
@MiloradFilipovic MiloradFilipovic changed the title (feat)editor: Add support for notice credentials properties (feat)editor: Add support for notice credentials properties Nov 9, 2022
@MiloradFilipovic MiloradFilipovic changed the title (feat)editor: Add support for notice credentials properties feat(editor): Add support for notice credentials properties Nov 9, 2022
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 9, 2022
agobrech
agobrech approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@agobrech agobrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & LGTM

@MiloradFilipovic MiloradFilipovic merged commit de96def into master Nov 9, 2022
@MiloradFilipovic MiloradFilipovic deleted the N8N-5393-notice-component-improvements branch November 9, 2022 13:50
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Nov 9, 2022
@janober
Copy link
Member

janober commented Nov 10, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agobrech agobrech agobrech approved these changes

Assignees

@MiloradFilipovic MiloradFilipovic

Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiloradFilipovic @janober @agobrech