Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Start supporting node.js 18 #4518

Merged
merged 4 commits into from
Nov 7, 2022
Merged

ci: Start supporting node.js 18 #4518

merged 4 commits into from
Nov 7, 2022

Conversation

netroy
Copy link
Member

@netroy netroy commented Nov 3, 2022

Node.js 18 becomes the active LTS on 2022-10-25, as Node.js 16 goes into maintenance mode.
https://github.com/nodejs/Release#release-schedule.

We'll should still continue to support Node.js 14 and 16 until they are End-of-life.

@netroy netroy requested a review from ivov November 3, 2022 13:31
@linear
Copy link

linear bot commented Nov 3, 2022

N8N-4793

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 3, 2022
Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending to check docker images.

.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
.nvmrc Outdated Show resolved Hide resolved
.github/workflows/ci-postgres-mysql.yml Outdated Show resolved Hide resolved
@netroy netroy requested a review from ivov November 4, 2022 11:27
ivov
ivov previously approved these changes Nov 4, 2022
Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested main and custom Docker images, confirmed working.

Pending conflict to resolve.

@netroy netroy changed the title ci: start supporting node.js 18 ci: Start supporting node.js 18 Nov 4, 2022
@netroy
Copy link
Member Author

netroy commented Nov 4, 2022

conflict resolved

Node.js 18 becomes the active LTS on 2022-10-25, as Node.js 16 goes into maintenance mode.
https://github.com/nodejs/Release#release-schedule
Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to keep n8n-custom image at 16 like the others?

Otherwise LGTM.

@netroy
Copy link
Member Author

netroy commented Nov 7, 2022

Any reason not to keep n8n-custom image at 16 like the others?

Otherwise LGTM.

Using the n8n-custom image as a test for node 18. That way we can have the nightly image use node 18 for a while before we switch everything over to 18.

@netroy netroy merged commit 9ee292c into master Nov 7, 2022
@netroy netroy deleted the N8N-4793-switch-to-node-18 branch November 7, 2022 14:51
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Nov 7, 2022
netroy added a commit that referenced this pull request Nov 7, 2022
netroy added a commit that referenced this pull request Nov 7, 2022
Revert "ci: Start supporting node.js 18 (#4518)"

This reverts commit 9ee292c.
MiloradFilipovic added a commit that referenced this pull request Nov 8, 2022
* master:
  fix(editor): Fix for incorrect execution saving indicator in executions view (#4547)
  feat(API): Report unhandled app crashes to Sentry (#4548)
  fix(SendInBlue Trigger Node): fix typo in credential name (#4357)
  refactor(core): Update rule typescript-eslint/no-unused-vars to not error when variable starts with _ (#4523)
  refactor: make IPollFunctions emit consistent with trigger emit (#4201)
  feat: Add cypress e2e tests for signup and signin (#3490)
  fix(core): Fix manual execution of pinned trigger on main mode (#4535)
  fix(HTTP Request Node): Show error cause in the output (#4538)
  refactor(core): Skip interim updates check (no-changelog) (#4536)
  ci: Revert support for node.js 18 (#4518) (#4537)
  ci: Start supporting node.js 18 (#4518)
@janober
Copy link
Member

janober commented Nov 10, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Nov 10, 2022
@netroy netroy restored the N8N-4793-switch-to-node-18 branch March 27, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants