-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Start supporting node.js 18 #4518
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending to check docker images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested main and custom Docker images, confirmed working.
Pending conflict to resolve.
c503158
to
7b6d4cf
Compare
conflict resolved |
Node.js 18 becomes the active LTS on 2022-10-25, as Node.js 16 goes into maintenance mode. https://github.com/nodejs/Release#release-schedule
7b6d4cf
to
68fdff4
Compare
6f7a14d
to
b55d874
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason not to keep n8n-custom
image at 16 like the others?
Otherwise LGTM.
Using the |
* master: fix(editor): Fix for incorrect execution saving indicator in executions view (#4547) feat(API): Report unhandled app crashes to Sentry (#4548) fix(SendInBlue Trigger Node): fix typo in credential name (#4357) refactor(core): Update rule typescript-eslint/no-unused-vars to not error when variable starts with _ (#4523) refactor: make IPollFunctions emit consistent with trigger emit (#4201) feat: Add cypress e2e tests for signup and signin (#3490) fix(core): Fix manual execution of pinned trigger on main mode (#4535) fix(HTTP Request Node): Show error cause in the output (#4538) refactor(core): Skip interim updates check (no-changelog) (#4536) ci: Revert support for node.js 18 (#4518) (#4537) ci: Start supporting node.js 18 (#4518)
Got released with |
Node.js 18 becomes the active LTS on 2022-10-25, as Node.js 16 goes into maintenance mode.
https://github.com/nodejs/Release#release-schedule.
We'll should still continue to support Node.js 14 and 16 until they are End-of-life.