Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(public-api): Fix error updating workflow with property not defined in the schema #4089

Merged
merged 2 commits into from
Sep 14, 2022
Merged

fix(public-api): Fix error updating workflow with property not defined in the schema #4089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfa8165
fix(cli): catch errors on updating workflow
mieky Sep 13, 2022
cbda0e6
:zap: Don\'t allow additionalProperties in the workflow schema
RicardoE105 Sep 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/cli/src/PublicApi/v1/handlers/workflows/spec/schemas/workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
type: object
additionalProperties: false
required:
- name
- nodes
Expand Down
8 changes: 7 additions & 1 deletion packages/cli/src/PublicApi/v1/handlers/workflows/workflows.handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,13 @@ export = {
await workflowRunner.remove(id.toString());
}

await updateWorkflow(sharedWorkflow.workflowId, updateData);
try {
await updateWorkflow(sharedWorkflow.workflowId, updateData);
} catch (error) {
if (error instanceof Error) {
return res.status(400).json({ message: error.message });
}
}

if (sharedWorkflow.workflow.active) {
try {
Expand Down