Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(nodes-base): Apply lint rule node-param-operation-option-description-wrong-for-get-many #4064

Merged
merged 8 commits into from
Sep 13, 2022
Merged

refactor(nodes-base): Apply lint rule node-param-operation-option-description-wrong-for-get-many #4064

merged 8 commits into from
Sep 13, 2022

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Sep 9, 2022

No description provided.

@ivov ivov added n8n team Authored by the n8n team node/linting Applies rule from eslint-plugin-n8n-nodes-base tech debt labels Sep 9, 2022
@ivov ivov changed the title Apply node-param-operation-option-description-wrong-for-get-many refactor(nodes-base): Apply lint rule node-param-operation-option-description-wrong-for-get-many Sep 9, 2022
Joffcom
Joffcom approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@Joffcom Joffcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@ivov ivov merged commit 3a9c7ac into master Sep 13, 2022
@ivov ivov deleted the apply-node-param-operation-option-description-wrong-for-get-many branch September 13, 2022 10:36
@Akityo Akityo mentioned this pull request Sep 13, 2022
Closed
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Sep 13, 2022
@janober
Copy link
Member

janober commented Sep 15, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Sep 15, 2022
@Saad-ISAA Saad-ISAA mentioned this pull request Sep 15, 2022
Open
This was referenced Sep 15, 2022
Open
Open
Open
Open
@MauGal MauGal mentioned this pull request Sep 16, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 16, 2022
Open
@viiy viiy mentioned this pull request Sep 16, 2022
Open
@Saad-ISAA Saad-ISAA mentioned this pull request Sep 16, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 16, 2022
Open
@MauGal MauGal mentioned this pull request Sep 16, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 16, 2022
Open
@Susangriffis Susangriffis mentioned this pull request Sep 16, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 16, 2022
Open
@Susangriffis Susangriffis mentioned this pull request Sep 16, 2022
Open
@viiy viiy mentioned this pull request Sep 22, 2022
Open
@MauGal MauGal mentioned this pull request Oct 6, 2022
Open
valya pushed a commit to valya/n8n that referenced this pull request Nov 8, 2022
@ivov
refactor(nodes-base): Apply lint rule `node-param-operation-option-de…
6950fa2 
…scription-wrong-for-get-many` (n8n-io#4064)

* 👕 Enable rule

* ⬆️ Upgrade linter

* 📦 Update `package-lock.json`

* 👕 Apply rule

* ✏️ Fix plurals

* ✏️ More typos

* ✏️ Final typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joffcom Joffcom Joffcom approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/linting Applies rule from eslint-plugin-n8n-nodes-base tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivov @janober @Joffcom