Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): reduce the size of alpine docker images #3973

Merged
merged 2 commits into from
Aug 31, 2022

Conversation

netroy
Copy link
Member

@netroy netroy commented Aug 30, 2022

  • reduce redundant code between the two alpine Dockerfiles
  • reduce the docker image build times
  • reduce the n8n image size from 671MB to 460MB
  • reduce the n8n-custom image size from 1.17GB to 462MB
  • reduce the size of npm tree by making all typing packages devDependencies

Partially resolves this ticket: N8N-3252

@netroy netroy requested review from ahsanv and ivov August 30, 2022 04:19
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Aug 30, 2022
@netroy netroy requested a review from agentreno August 31, 2022 09:21
Copy link
Contributor

@agentreno agentreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! 👍 i left a few comments (some for my own education, one to discuss)

.github/workflows/docker-base-image.yml Show resolved Hide resolved
.github/workflows/docker-base-image.yml Show resolved Hide resolved
docker/images/n8n-custom/Dockerfile Show resolved Hide resolved
docker/images/n8n-custom/Dockerfile Show resolved Hide resolved
@netroy netroy requested review from agentreno and csuermann and removed request for ahsanv, ivov and agentreno August 31, 2022 10:54
csuermann
csuermann previously approved these changes Aug 31, 2022
* reduce redundant code between the two alpine Dockerfiles
* reduce the docker image build times
* reduce the `n8n` image size from 1.17GB to 462MB
* reduce the `n8n-custom` image size from 671MB to 460MB
* reduce the size of npm tree by making all typing packages devDependencies

Partially resolves this ticket: N8N-3252
@netroy netroy merged commit 398adb2 into master Aug 31, 2022
@netroy netroy deleted the N8N-3252-slim-docker branch August 31, 2022 13:25
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Aug 31, 2022
@janober
Copy link
Member

janober commented Aug 31, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Aug 31, 2022
valya pushed a commit to valya/n8n that referenced this pull request Nov 8, 2022
* reduce redundant code between the two alpine Dockerfiles
* reduce the docker image build times
* reduce the `n8n` image size from 1.17GB to 462MB
* reduce the `n8n-custom` image size from 671MB to 460MB
* reduce the size of npm tree by making all typing packages devDependencies

Partially resolves this ticket: N8N-3252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants