Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N8N-4126 credentials injection and testing on specific nodes #3816

Merged
merged 22 commits into from
Aug 24, 2022
Merged

N8N-4126 credentials injection and testing on specific nodes #3816

merged 22 commits into from
Aug 24, 2022

Conversation

agobrech
Copy link
Contributor

@agobrech agobrech commented Aug 2, 2022

No description provided.

@agobrech agobrech changed the title n8n-4126 credentials injection and testing on specific nodes N8N-4126 credentials injection and testing on specific nodes Aug 2, 2022
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Aug 2, 2022
krynble
krynble suggested changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Ael!

Thanks for all the effort. I've found some things not working fine and I've left a few comments.

packages/nodes-base/credentials/LemlistApi.credentials.ts Show resolved Hide resolved
packages/nodes-base/credentials/Aws.credentials.ts Outdated Show resolved Hide resolved
packages/nodes-base/credentials/Aws.credentials.ts Outdated Show resolved Hide resolved
packages/nodes-base/credentials/Aws.credentials.ts Outdated Show resolved Hide resolved
packages/nodes-base/credentials/Aws.credentials.ts Outdated Show resolved Hide resolved
packages/nodes-base/nodes/Aws/Textract/GenericFunctions.ts Outdated Show resolved Hide resolved
packages/nodes-base/credentials/UProcApi.credentials.ts Outdated Show resolved Hide resolved
@krynble krynble merged commit 76f9ad8 into master Aug 24, 2022
@krynble krynble deleted the n8n-4126-credentials-injection-and-testing-on-specifi-nodes branch August 24, 2022 08:26
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Aug 24, 2022
@janober
Copy link
Member

janober commented Aug 24, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Aug 24, 2022
@saurabharch saurabharch mentioned this pull request Feb 11, 2024
Closed
@reconsumeralization reconsumeralization mentioned this pull request Feb 11, 2024
Open
@johnperez416 johnperez416 mentioned this pull request Feb 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krynble krynble krynble approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agobrech @janober @krynble