Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #3540] Handle iterator request bodies in convertN8nRequestToAxios #3567

Merged
merged 3 commits into from
Aug 15, 2022
Merged

[Fix #3540] Handle iterator request bodies in convertN8nRequestToAxios #3567

merged 3 commits into from
Aug 15, 2022

Conversation

netroy
Copy link
Member

@netroy netroy commented Jun 21, 2022

Since this change, when the request body is an iterator object (like URLSearchParams), no body is sent.

Fixes #3540

@netroy netroy mentioned this pull request Jun 21, 2022
Closed
@n8n-assistant n8n-assistant bot added community Authored by a community member core Enhancement outside /nodes-base and /editor-ui labels Jun 21, 2022
@pemontto
Copy link
Contributor

pemontto commented Jul 8, 2022

Similar to
#3620
#3621

I was wondering what happens when the body is a buffer or raw string and not an object.

krynble
krynble approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution! LGTM!

@krynble krynble merged commit e3f0ee6 into n8n-io:master Aug 15, 2022
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Aug 15, 2022
@janober
Copy link
Member

janober commented Aug 17, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Aug 17, 2022
@netroy netroy deleted the fix-3540 branch August 17, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krynble krynble krynble approved these changes

Assignees
No one assigned
Labels
community Authored by a community member core Enhancement outside /nodes-base and /editor-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

httpRequest with URLSearchParams body does not work anymore
4 participants
@netroy @pemontto @janober @krynble