Re-version HTTP request node #3215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivov
commented
Apr 28, 2022
| function getCredPaths(root = NODES_BASE_ROOT): string[] { | ||
| const packageJson = require(path.resolve(root, 'package.json')); | ||
|
|
||
| return deduplicate(packageJson.n8n.credentials); |
There was a problem hiding this comment.
Prevent Vue unique key complaints from duplicates in package.json.
ivov
added
feature
krynble
suggested changes
Apr 28, 2022
| const requestMethod = this.getNodeParameter('requestMethod', 0) as string; | ||
| const parametersAreJson = this.getNodeParameter('jsonParameters', 0) as boolean; | ||
| let authenticateWith; | ||
| let isHttpRequestNodeVersion1 = false; |
There was a problem hiding this comment.
Is it possible to use this.getNode().typeVersion instead of trying to fetch a parameter? I am not sure if this would work but it seems to be a safer bet and also a better example for the future.
Comment on lines
27
to
52
| { | ||
| displayName: 'Display V1', | ||
| name: 'versionTest', | ||
| type: 'number', | ||
| displayOptions: { | ||
| show: { | ||
| '@version': [ | ||
| 1, | ||
| ], | ||
| }, | ||
| }, | ||
| default: 1, | ||
| }, | ||
| { | ||
| displayName: 'Display V2', | ||
| name: 'versionTest', | ||
| type: 'number', | ||
| displayOptions: { | ||
| show: { | ||
| '@version': [ | ||
| 2, | ||
| ], | ||
| }, | ||
| }, | ||
| default: 2, | ||
| }, |
There was a problem hiding this comment.
I think these changes to the Set node can be undone, their purpose was to showcase how this can be used, right?
| @@ -187,6 +213,10 @@ export class Set implements INodeType { | |||
| } | |||
| }); | |||
|
|
|||
|
|
|||
| newItem.json.versionFromParameter = this.getNodeParameter('versionTest', itemIndex); | |||
| newItem.json.versionFromNode = this.getNode().typeVersion; | |||
There was a problem hiding this comment.
Here is an example of what I mentioned about fetching current node version
|
Thank you @krynble, comments addressed. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reversioned with #3205, only HTTPRN relevant for review.