Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export and Import Workflow Tags #2653

Closed
wants to merge 1 commit into from
Closed

Export and Import Workflow Tags #2653

wants to merge 1 commit into from

Conversation

Lucaber
Copy link
Contributor

@Lucaber Lucaber commented Jan 7, 2022

Support exporting and importing tags of workflows via frontend and cli.

On export, all tag data is included in the json.

  • id
  • name
  • updatedAt
  • createdAt

When importing a workflow json to n8n we:

  • first check if a tag with the same id and createdAt date exists in the
    database, then we can assume the tag is identical. Changes on the name
    of the tag are now preserved.
  • check if a tag with the same name exists on the database.
  • create a new tag with the given name.

@CLAassistant
Copy link

CLAassistant commented Jan 7, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ivov ivov added core Enhancement outside /nodes-base and /editor-ui community Authored by a community member labels Jan 10, 2022
@VonRehberg
Copy link

Nice!
I need this feature :-)

@Lucaber
Copy link
Contributor Author

Lucaber commented Feb 1, 2022

I'm not able to replicate the Codacy issues with yarn lint locally. Is Codacy using a different eslint config/version? @ivov

@thueske
Copy link

thueske commented Mar 18, 2022

Hello, this PR has been lying around here for 3 months. We need this feature urgently. Is there anything else we can do on our part to get this merged? @ivov @janober @mutdmour

@mutdmour
Copy link
Contributor

Hello. Thanks for highlighting. Will take a look and prioritise for this week's release.

@Lucaber
Export and Import Workflow Tags
c903c52 
Support exporting and importing tags of workflows via frontend and cli.

On export, all tag data is included in the json.
- id
- name
- updatedAt
- createdAt

When importing a workflow json to n8n we:
- first check if a tag with the same id and createdAt date exists in the
  database, then we can assume the tag is identical. Changes on the name
  of the tag are now preserved.
- check if a tag with the same name exists on the database.
- create a new tag with the given name.
@mutdmour
Copy link
Contributor

mutdmour commented Apr 1, 2022

update - I have started looking at this but there were a few issues on the FE when importing/exporting tags that needed addressing (started that here https://github.com/n8n-io/n8n/tree/lucaber-import-tags).
@nivb06 is leading initiative to merge in community PRs and I have asked him to prioritise this.

@martin-helmich
Copy link

Any updates on this? Anything we can do to expedite the code review on this?

@janober
Copy link
Member

janober commented Jun 2, 2022

Closing PR in favor of #3130 which is based on this.

@janober janober closed this Jun 2, 2022
@janober janober added the Upcoming Release Will be part of the upcoming release label Jun 2, 2022
@janober
Copy link
Member

janober commented Jun 7, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community Authored by a community member core Enhancement outside /nodes-base and /editor-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Lucaber @CLAassistant @VonRehberg @thueske @mutdmour @martin-helmich @janober @ivov