-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding an optional database field to redis #2634
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivov
added
node/improvement
New feature or request
community
Authored by a community member
labels
Jan 5, 2022
Great, thanks a lot for your contribution @hnb2 ! Got merged. |
Got released with |
LefebvreJonathan
added a commit
to hop3team/n8n
that referenced
this pull request
Jan 19, 2022
* ✏️ Write documentation * ⚡ Account for multiple headers in single translation file * 🔥 Remove unused translations output * ⚡ Add missing translations to fixed collection * ✏️ Clarify deep nesting in collections * ⚡ Clean up dummy node translation * ✏️ Clean up docs images * 👕 Fix lint * ✏️ Enlarge docs images * ✏️ More docs images touchups * ✏️ Split docs images * 🔨 Restore .gitignore and VSCode settings * ✏️ Minor docs fixes * ✏️ Improve wording * ⚡ Alphabetize locale files * ✏️ Improve docs copy * ⚡ Switch to JSON for localization service * ✏️ Update TS with JSON * 🔥 Remove semicolons from JSON * 🐛 Fix rendering for node titles * ⚡ Update string to latest version * 🐛 Fix unique node name creation * ⚡ Add braces to condition * ⚡ Use mapGetters to simplify calls * ⚡ Reduce calls to config object * 🔥 Remove old solution leftover * ⚡ Add condition for loading cred translations * ⚡ Fix hard-coded locale identifier * ⚡ Render strings for ReadOnly * 🔥 Replace require() to prevent caching * ⚡ Render missing strings in ExecutionDetails * ⚡ Prevent race condition with headers * ⚡ Populate translations without blocking * ⚡ Integrate number suffix fix * 🔥 Remove logging * ⚡ Fix wrong closing brace * ⚡ Fix category of read only strings * 🐛 Fix HTML rendering in read only component * 📦 Update package-lock.json * ⚡ Fix build issues * ⚡ Update personalization modal strings * 🔥 Remove error message * 📦 Update package-lock.json * ⚡ Render string in plus endpoint * ⚡ Improve plus endpoint string rendering * ✏️ Rename key * ⚡ Initial plugin implementation * ⚡ Adjust all calls * 🔥 Remove mixin-related lines * 🚚 Rename $i18n2 to $i * ⚡ Bring setup logic to plugin * ✨ Add option to ignore requests from bots * ⚡ Add codex files (n8n-io#2566) * 🐛 Fix personalization survey merge * 📦 Update package-lock.json * 🚚 Rename $i to $locale * 🚚 Relocate i18n README * ⚡ Fix README image links * ⚡ Add user agent field to Plivo-Node (n8n-io#2572) * 🐛 Fix typo in method call * 🐛 Fix save label in workflow settings * 🐛 Fix node not found text * 🐛 Add missing text for chooseOrCreateATag * 🔥 Remove node color in settings * 📦 Update package-lock.json * 🔥 Remove unneeded parens * 🐛 Fix typo in method call * 🔥 Remove unneeded colon * 🐛 Fix number-formatting call * 🔥 Remove dummy translations * 🐛 Prevent clicks bubbling to main view (n8n-io#2580) * ✨ Add support for backspace (n8n-io#2551) * 🐛 Fix due_datetime formatting on Todoist (n8n-io#2491) * Fixed due_datetime formatting Signed-off-by: Ivan Lebedev <[email protected]> * Option to specify due_string language Signed-off-by: Ivan Lebedev <[email protected]> * Removed debug imports Signed-off-by: Ivan Lebedev <[email protected]> * 🐛 Fix UpdatedPanel not closing (n8n-io#2563) * ⬆️ Update package-lock.json file * 🔖 Release [email protected] * 🔖 Release [email protected] * ⬆️ Set [email protected] and [email protected] on n8n * 🔖 Release [email protected] * ⚡ Remove Mattermost translation dummy data * 🔖 Release [email protected] * ⬆️ Set [email protected] on n8n * 🔖 Release [email protected] * 🔖 Release [email protected] * ⬆️ Set [email protected] on n8n-core * 🔖 Release [email protected] * ⬆️ Set [email protected] and [email protected] on n8n-nodes-base * 🔖 Release [email protected] * ⬆️ Set [email protected] on n8n-editor-ui * 🔖 Release [email protected] * ⬆️ Set [email protected], [email protected], [email protected] and [email protected] on n8n * 🔖 Release [email protected] * 👕 Fix lint issue * ⚡ Add missing webhook key * ⚡ Add missing method call * ⚡ Deprecate number formatting This was a minor convenience feature but out of scope for MVP. Needs refactoring for future usage in plugin. * ⚡ Add missing integrated key * 🐛 Fix syntax that it displays correctly * 🔖 Release [email protected] * ⬆️ Set [email protected] on n8n * 🔖 Release [email protected] * ⚡ Change background color and add $json autocomplete * ⚡ Fix syntax error and disable minimap * ⚡ Fix theme name * Add SpaceID in Create Work Item for Kitemaker * ⚡ Add Google native files support to file:download - Google Drive (n8n-io#2372) * ⚡ Add Google native files support to file:download * ⚡ Small fix * ⚡ Improvements * ⚡ Fix lint issue * ⚡ Improvements * ⚡ Remove console.log Co-authored-by: Jan Oberhauser <[email protected]> * Expose pleaseParse-functionality in n8n interface * ⚡ Improve autocomplete and a few other changes * ⚡ Minor i18n fixes (n8n-io#2585) * ⚡ Make subcategory render keys consistent * ⚡ Add missing or key * ⚡ Fix default text for multiple value button * ⚡ Simplify subcategory extraction * ⚡ Deprecate step size and node color (n8n-io#2586) * 🔥 Deprecate numberStepSize * 🔥 Deprecate color in non-FA nodes * ⚡ Minor node name fixes * 📦 Update package-lock.json * ⏪ Restore Merge node color * 👕 Fix lint * ⚡ Fix lint issue and comparison * ⚡ Add line numbers to errors * 🐛 Fix issue with no incoming data * Add functionality back to Node * Expose functionality for update * 🐛 Fix issue with comments in last line * ⚡ Improve default types if there is not execution data * ⚡ Further improve default types * 🐛 Add support for data from not first output data * ⚡ Improvements * ⚡ Improve axios output to be more identical to request (n8n-io#2588) * ✨ Introduce binary data management (n8n-io#2059) * introduce binary data management * merge fixes * fixes * init binary data manager for other modes * improve binary manager * improve binary manager * delete binary data on executions delete * lazy delete non-saved executions binary data * merge fixes + error handing * improve structure * leftovers and cleanups * formatting * fix config description * fixes * fix races * duplicate binary data for execute workflow node * clean up and cr * update mode name, add binary mode to diagnostics * update mode name, add prefix to filename * update filename * allow multiple modes, backward compatibility * improve file and id naming * use execution id for binary data storage * delete binary data by execution id * add meta for persisted binary data * delete marked persisted files * mark deletion by executionid * add env var for persisted binary data ttl * improvements * lint fix * fix env var description * cleanup * cleanup * ⚡ Minor improvements Co-authored-by: Jan Oberhauser <[email protected]> * ✨ Make it possible to disable the UI * 🐛 Display correct expression result for not first output data * ⚡ Automatically remove new lines from Google credentials * ⚡ Add missing gitlab trigger event types (n8n-io#2591) See issue n8n-io#2590 * ⚡ Parse single-line private key for Google service account (n8n-io#2132) * ⚡ Parse single-line private key * ✏️ Update description and placeholder * ⚡ Some improvements Co-authored-by: Jan Oberhauser <[email protected]> Co-authored-by: Jan Oberhauser <[email protected]> * ⚡ Minor improvement * ⚡ Add executionId workflow.postExecute external hook (n8n-io#2569) Co-authored-by: Jan Oberhauser <[email protected]> * 👕 Fix lint issue * ⬆️ Update package-lock.json file * 🔖 Release [email protected] * ⬆️ Set [email protected] on n8n-core * 🔖 Release [email protected] * ⬆️ Set [email protected] and [email protected] on n8n-node-dev * 🔖 Release [email protected] * ⬆️ Set [email protected] and [email protected] on n8n-nodes-base * 🔖 Release [email protected] * ⬆️ Set [email protected] on n8n-editor-ui * 🔖 Release [email protected] * ⬆️ Set [email protected], [email protected], [email protected] and [email protected] on n8n * 🔖 Release [email protected] * ✨ Add Notion node V2 (n8n-io#2437) * ⚡ Add versioning * ⚡ Add credentials verification * ⚡ Add folmula filtering * ⚡ Add file support * ⚡ Apply internal review * ⚡ Improvements * ⚡ Add page updated event to trigger * ⚡ Use name instead of id when setting expression in select type * ⚡ improvements * ⚡ Improvements * ⚡ Improvement to descriptions * ⚡ Add filter to databasePage:getAll * ⚡ Improvements * ⚡ Add database:search operation * ⚡ Add page:archive operation * ⚡ Allow clearing fields date type * ⚡ Allow setting single value in people type field * asasas * asasas * aaaaa * ⚡ Improvements * ⚡ Fix merging issues * 🐛 Fix filename * ⚡ Minor fix Co-authored-by: Jan Oberhauser <[email protected]> * ✨ Add engagement resource - Hubspot Node (n8n-io#2615) * ⚡ Add engagement resource * ⚡ Improvements * 🐛 Fix forObjectType:contact Co-authored-by: Jan Oberhauser <[email protected]> * 🐛 Fix digest-auth (n8n-io#2577) * 🚢 Added digest-header package to get auth * ⚡ Fix type issue and digest auth header request * ⚡ Removed auth details from first request * Added diest to authorization header * ⚡ fixed typo in url * ⚡ Removed broken package and addded auth implimentation * ⚡ Added check for www header * 👕 Moved digestAuth to a specific function * 👕 Code restructuring * ⚡ Added seperate promise for digest-auth * 👕 Fix formatting * 👕 renamed digestPromise to axiosPromise * 👕 Removed redundant silce function * ⚡ Fix parameter "Ignore Bots" parameter order * ⚡ Add codex files for Figma and Workable (n8n-io#2623) * 🐛 Fix number suffix in duplicate node (n8n-io#2602) * 🐛 Fix number suffix in duplicate node * 🔥 Remove logging * ⚡ Always stringify data of Function-Nodes (n8n-io#2606) * ⚡ Always stringify data of Function-Nodes * ⚡ Fix lint issue and fix data * ⬆️ Update package-lock.json file * 🔖 Release [email protected] * ⬆️ Set [email protected] on n8n-node-dev * 🔖 Release [email protected] * ⬆️ Set [email protected] on n8n-nodes-base * 🔖 Release [email protected] * 🔖 Release [email protected] * ⬆️ Set [email protected], [email protected] and [email protected] on n8n * 🔖 Release [email protected] * 🐛 Binary data handling fixes (n8n-io#2629) * Update node airtable * Update nodenextcloud * Update node spreadsheet * Update node cortex, dropbox, editImage nodes * Update node emailSend * Update node ftp * Update node googleDrive * Update node googleDrive fix * Update node youtube * Update node htmlExtract * Update node linkedIn * Update node mailgun * Update node matrix * Update node pipedrive * Update node readPdf * Update node facebookGraphApi * Update node httpRequest * Update node nocoDB * Update node httpRequest, respondToWebhook * Update node signi4 * Update node slack * Update node zulip * cleanup * fix generic funcs * 🐛 Fix EditImage Node Co-authored-by: Jan Oberhauser <[email protected]> * 🐛 Fix execute commands after binary data release (n8n-io#2628) * 🔖 Release [email protected] * ⬆️ Set [email protected] on n8n * 🔖 Release [email protected] * ⚡ Improve telemetry (n8n-io#2604) * add node positions in node graph * add hover events * add tag count in save event * populate properties when default * fix delete and enable node events * add node and workflow exec events * lint * add node graph * add node id * ✨ Add Syncromsp node (n8n-io#2477) * Init Node * Added get customer details api for syncomsp-node * Fixed formatting bug 🐛 * Updated description for query params, and removed redundant condition in router * Changed default value for page parameter * 🚢 Added tickets API * 🚢 Added contacts API * 🚢 Added RMM Alerts API * Add customer API * Updates post code review * Rename SyncroMspAPI.credentials.ts to SyncroMspApi.credentials.ts * added create and delete method to customers module * fix liniting issue * Added Update method to customer module * Code Review Changes * 🚢 Added CRUD for contacts endpoint * 🚢 Added CRUD for RMM Alert endpoint * Added options for status field * 🐛 fix linting issues * Init Node * Added get customer details api for syncomsp-node * Fixed formatting bug 🐛 * Updated description for query params, and removed redundant condition in router * Changed default value for page parameter * 🚢 Added tickets API * 🚢 Added contacts API * 🚢 Added RMM Alerts API * Updates post code review * Add customer API * added create and delete method to customers module * fix liniting issue * Added Update method to customer module * Rename SyncroMspAPI.credentials.ts to SyncroMspApi.credentials.ts * Code Review Changes * 🚢 Added CRUD for contacts endpoint * 🚢 Added CRUD for RMM Alert endpoint * Added options for status field * 🐛 fix linting issues * 🚢 Added CRUD for ticket endpoint * :tag: update get customer module * :tag: update get customer module * Minor bug fixes * Changed response for ticket update * 👕 Fix lint issue * Alphabetically ordered all options * 🐛 Fixed build issue * 🐛 Fixed Server.ts build issue, rebased from master * ⚡ Fix node issues * ⚡ Fix more issues * ⚡ Fixed all operations with the standard convention * 👕 Fix lint * Fix reviewed changes * update border color * ⚡ minor fixes * minor fixes * Added fallback when port in use * ⚡ Minor Fixes * ⚡ Hide addtional paramerts when return all is active * ⚡ Fix issues with Tickets * ⚡ Fix issues with Rmm * ⚡ Fix issues with Customer * 👕 Fix lint * ⚡ Fix issues with Contact * 👕 Fixed formatting issue * ⚡ Return 404 in ID not found * 👕 Fixed formatting issue * ⚡ Improvements * ⚡ Improvements * ⚡ Improvements * ⚡ Add credentials verification * ⚡ Improvements * ⚡ Improvements * ⚡ Additional improvements Co-authored-by: Jan Oberhauser <[email protected]> Co-authored-by: ricardo <[email protected]> * 🐛 Fix bug that two items get returned * ✨ Make it possible to add transparency to an image * 🐛 Fix personalisation bug (n8n-io#2652) * fix personlization bug * fix translation issues * fix suggested nodes * update key * ⚡ i18n feedback refactorings (n8n-io#2597) * ⚡ Create endpoint for node credential translation * ⚡ Add API helper method in FE * 🔨 Add creds JSON files to tsconfig * ⚡ Refactor credentials loading * ⚡ Refactor calls in CredentialConfig * ✏️ Add dummy translations * ⚡ Split translations per node * 🔥 Remove deprecated method * ⚡ Refactor nesting in collections * 🚚 Rename topParameter methods for accuracy * ✏️ Fill out GitHub dummy cred * 🚚 Clarify naming for collection utils * ✏️ Fill out dummy translation * 🔥 Remove surplus colons * 🔥 Remove logging * ⚡ Restore missing space * 🔥 Remove lingering colon * ⚡ Add path to InputLabel calls * ✏️ Fill out dummy translations * 🐛 Fix multipleValuesButtonText logic * ⚡ Add sample properties to be deleted * ⚡ Render deeply nested params * 📦 Update package-lock.json * 🔥 remove logging * ✏️ Add dummy value to Slack translation * ✏️ Add placeholder to dummy translation * ⚡ Fix placeholder rendering for button text * 👕 Fix lint * 🔥 Remove outdated comment * 🐛 Pass in missing arg for placeholder * ✏️ Fill out Slack translation * ⚡ Add explanatory comment * ✏️ Fill out dummy translation * ✏️ Update documentation * 🔥 Remove broken link * ✏️ Add pending functionality * ✏️ Fix indentation * 🐛 Fix method call in CredentialEdit * ⚡ Implement eventTriggerDescription * 🐛 Fix table-json-binary radio buttons * ✏️ Clarify usage of eventTriggerDescription * 🔥 Remove unneeded arg * 🐛 Fix display in CodeEdit and TextEdit * 🔥 Remove logging * ✏️ Add translation for test cred options * ✏️ Add test for separate file in same dir * ✏️ Add test for versioned node * ✏️ Add test for node in grouped dir * ✏️ Add minor clarifications * ✏️ Add nested collection test * ✏️ Add pending functionality * ⚡ Generalize collections handling * 🚚 Rename helper to remove redundancy * 🚚 Improve naming in helpers * ✏️ Improve helpers documentation * ✏️ Improve i18n methods documentation * 🚚 Make endpoint naming consistent * ✏️ Add final newlines * ✏️ Clean up JSON examples * ⚡ Reuse i18n method * ⚡ Improve utils readability * ⚡ Return early if cred translation exists * 🔥 Remove dummy translations * ✨ Add Supabase node (n8n-io#2549) * ✨ Supabase node * ⚡ Improvements * ⚡ Improvements * ⚡ Improvements * ⚡ Improvements * ⚡ Minor improvements Co-authored-by: Jan Oberhauser <[email protected]> * ✨ Add MS Graph Security node (n8n-io#2307) * ✨ Create MS Graph Security node * ⚡ General update * 📦 Update package-lock.json * 👕 Fix lint * 🔥 Remove Reviewed field * ⚡ Set max limit to 1000 * ⚡ Add limit to 1000 to second resource * 👕 Fix lint issue * 🐛 Fix VUE_APP_PUBLIC_PATH issue (n8n-io#2648) VUE_APP_PUBLIC_PATH was not working on Linux after this commit. * ✨ Add field AccountNumber to Salesforce Node (n8n-io#2649) * 🐛 Fix iCalendar month bug (n8n-io#2644) * 👕 Fix lint issue * :zap; Add wait alias to Merge node (n8n-io#2633) * ✨ Addi an optional database field to redis (n8n-io#2634) * ⚡ Add external hook "activeWorkflows.initialized" (n8n-io#2571) * 🐛 Fix issue that empty binary data overwrite others on merge * Revert "🐛 Fix VUE_APP_PUBLIC_PATH issue (n8n-io#2648)" (n8n-io#2655) This reverts commit c129252. * ⬆️ Update package-lock.json file * 🔖 Release [email protected] * ⬆️ Set [email protected] on n8n-core * 🔖 Release [email protected] * ⬆️ Set [email protected] and [email protected] on n8n-node-dev * 🔖 Release [email protected] * ⬆️ Set [email protected] and [email protected] on n8n-nodes-base * 🔖 Release [email protected] * ⬆️ Set [email protected] on n8n-editor-ui * 🔖 Release [email protected] * ⬆️ Set [email protected], [email protected], [email protected] and [email protected] on n8n * 🔖 Release [email protected] * 📖 Fix path to Supabase credential documentation (n8n-io#2660) * 🐛 Fix build issue n8n-io#2675 * 🐛 Fix tags i18n bug (n8n-io#2667) * 🐛 Fix Philips Hue API Connection (n8n-io#2631) * 🐛 Fix Philips Hue API Connection * Philips Hue Node: Fixed typo in update operation description * ⚡ Skip /node-dev during build (n8n-io#2677) * ✨ Add Jenkins Node (n8n-io#2345) * feat: initial jenkins setup * feat: trigger job functionality * feat: copy a job * feat: basic Jenkins instance operations * feat: create job from xml * feat: trigger with params * feat: basic build list * feat: list build with params * feat: basic credentials test * chore: linting fixes * feat: use baseUrl from credentials * chore: naming fixes * feat: filters collection for getall buils * fix: better ui and credentials * chore: alphabetize params and fix typos * ⚡ Small changes * ⚡ Improvements * ⚡ Improvements * ⚡ Improvements * ⚡ Improvements * ⚡ Improvements * ⚡ Improvements * ⚡ Some improvements Co-authored-by: ricardo <[email protected]> Co-authored-by: Jan Oberhauser <[email protected]> * ⚡ Add and update codex files (n8n-io#2679) * ✨ Add OAuth, basicAuth, digestAuth and queryAuth support to GraphQL node (n8n-io#2673) * ✨ Add OAuth support to GraphQL node * ✨ Add basicAuth, digestAuth and queryAuth to GraphQL node * 🐛 Fix download for some files via Box node (n8n-io#2669) * 📚 Fix typo in CONTRIBUTING.md (n8n-io#2662) * 👕 Fix lint issue * 👕 Remove redundant linting options (n8n-io#2626) * ⚡ Allow to use execute command with workflows that do not have an ID * 🐛 Fix bug filtering date and datetime fields on Salesforce node (n8n-io#2565) * ⬆️ Update package-lock.json file * 🔖 Release [email protected] * ⬆️ Set [email protected] on n8n-core * 🔖 Release [email protected] * ⬆️ Set [email protected] and [email protected] on n8n-node-dev * 🔖 Release [email protected] * ⬆️ Set [email protected] and [email protected] on n8n-nodes-base * 🔖 Release [email protected] * ⬆️ Set [email protected] on n8n-editor-ui * 🔖 Release [email protected] * ⬆️ Set [email protected], [email protected], [email protected] and [email protected] on n8n * 🔖 Release [email protected] * 📚 Minor i18n docs fixes (n8n-io#2689) * 🐛 Temporary change logging to fix memory issue * 🔖 Release [email protected] * ⬆️ Set [email protected] on n8n * 🔖 Release [email protected] * 📌 Pin chokidar verison (n8n-io#2696) Co-authored-by: Iván Ovejero <[email protected]> Co-authored-by: Ricardo Georgel <[email protected]> Co-authored-by: Jan Oberhauser <[email protected]> Co-authored-by: pemontto <[email protected]> Co-authored-by: Harshil Agrawal <[email protected]> Co-authored-by: Mohammed Huzaif <[email protected]> Co-authored-by: Mutasem Aldmour <[email protected]> Co-authored-by: Elvina Valieva <[email protected]> Co-authored-by: Лебедев Иван <[email protected]> Co-authored-by: Oliver Trajceski <[email protected]> Co-authored-by: Leo Lou <[email protected]> Co-authored-by: Ricardo Espinoza <[email protected]> Co-authored-by: Tim Adler <[email protected]> Co-authored-by: Omar Ajoue <[email protected]> Co-authored-by: Ahsan Virani <[email protected]> Co-authored-by: Manuel <[email protected]> Co-authored-by: Jan Oberhauser <[email protected]> Co-authored-by: Vahid Sebto <[email protected]> Co-authored-by: Anuj Kapoor <[email protected]> Co-authored-by: ricardo <[email protected]> Co-authored-by: m2scared <[email protected]> Co-authored-by: Laurens <[email protected]> Co-authored-by: Jonathan Bennetts <[email protected]> Co-authored-by: Pierre <[email protected]> Co-authored-by: Tom <[email protected]> Co-authored-by: Phil Clifford <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this is a tiny patch to add an optional field
database
to Redis credentials. It will allow users to select a different database for their operations instead of the default 0.It defaults on
0
as in not to break any current implementations. Theselect
operation will be run regardless the field is set or not, so maybe I can add a conditionif (database !== 0)
if necessary, but I think it is better to be explicit.Looking forward to some feedback.