Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor i18n fixes #2585

Merged
merged 4 commits into from
Dec 23, 2021
Merged

Minor i18n fixes #2585

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e8710a5
:zap: Make subcategory render keys consistent
ivov Dec 20, 2021
b49d871
:zap: Add missing or key
ivov Dec 20, 2021
86ed958
:zap: Fix default text for multiple value button
ivov Dec 20, 2021
ab2e031
:zap: Simplify subcategory extraction
ivov Dec 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/editor-ui/src/components/MultipleParameter.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ export default mixins(genericHelpers)
computed: {
addButtonText (): string {
if (
!this.parameter.typeOptions &&
!this.parameter.typeOptions.multipleValueButtonText
!this.parameter.typeOptions ||
(this.parameter.typeOptions && !this.parameter.typeOptions.multipleValueButtonText)
) {
return this.$locale.baseText('multipleParameter.addItem');
}
Expand Down
2 changes: 1 addition & 1 deletion packages/editor-ui/src/components/NodeCreator/NoResults.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
</div>
<div class="action">
{{ $locale.baseText('nodeCreator.noResults.dontWorryYouCanProbablyDoItWithThe') }}
<a @click="selectHttpRequest">{{ $locale.baseText('nodeCreator.noResults.httpRequest') }}</a> or
<a @click="selectHttpRequest">{{ $locale.baseText('nodeCreator.noResults.httpRequest') }}</a> {{ $locale.baseText('nodeCreator.noResults.or') }}
<a @click="selectWebhook">{{ $locale.baseText('nodeCreator.noResults.webhook') }}</a> {{ $locale.baseText('nodeCreator.noResults.node') }}
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions packages/editor-ui/src/components/NodeCreator/SubcategoryItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ export default Vue.extend({
return camelcase(this.item.properties.subcategory);
},
subcategoryDescription() {
const firstWord = this.item.properties.description.split(' ').shift() || '';
return firstWord.toLowerCase().replace(/,/g, '');
const subcategory = this.item.key.split('_').pop();
ivov marked this conversation as resolved.
Show resolved Hide resolved
return camelcase(subcategory);
},
},
});
Expand Down
9 changes: 5 additions & 4 deletions packages/editor-ui/src/plugins/i18n/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,7 @@
"dontWorryYouCanProbablyDoItWithThe": "Don’t worry, you can probably do it with the",
"httpRequest": "HTTP Request",
"node": "node",
"or": "or",
"requestTheNode": "Request the node",
"wantUsToMakeItFaster": "Want us to make it faster?",
"weDidntMakeThatYet": "We didn't make that... yet",
Expand All @@ -422,10 +423,10 @@
"searchNodes": "Search nodes..."
},
"subcategoryDescriptions": {
"branches": "Branches, core triggers, merge data",
"http": "HTTP Requests (API calls), date and time, scrape HTML",
"manipulate": "Manipulate data fields, run code",
"work": "Work with CSV, XML, text, images etc."
"dataTransformation": "Manipulate data fields, run code",
"files": "Work with CSV, XML, text, images etc.",
"flow": "Branches, core triggers, merge data",
"helpers": "HTTP Requests (API calls), date and time, scrape HTML"
},
"subcategoryNames": {
"dataTransformation": "Data Transformation",
Expand Down