Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Restore workers view #11876

Merged
merged 1 commit into from
Nov 26, 2024
Merged

fix(editor): Restore workers view #11876

merged 1 commit into from
Nov 26, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Nov 25, 2024

Summary

This PR #11509 accidentally removed an import for WorkerCard

Context: https://n8nio.slack.com/archives/C035KBDA917/p1732541195112039

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@ivov ivov added the release/backport Changes that need to be backported to older releases. label Nov 25, 2024
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Nov 25, 2024

n8n    Run #8072

Run Properties:  status check failed Failed #8072  •  git commit ad41e74f0a: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project n8n
Branch Review fix-workers-view
Run status status check failed Failed #8072
Run duration 04m 14s
Commit git commit ad41e74f0a: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Committer Iván Ovejero
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 267
View all changes introduced in this branch ↗︎

Tests for review

Failed  42-nps-survey.cy.ts • 2 failed tests

View Output Video

Test Artifacts
NpsSurvey > shows nps survey to recently activated user and can submit email Test Replay Screenshots Video
NpsSurvey > allows user to ignore survey 3 times before stopping to show until 6 months later Test Replay Screenshots Video
Failed  20-workflow-executions.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  30-editor-after-route-changes.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  45-workflow-selector-parameter.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  6-code-node.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 50 specs in Cypress Cloud.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ackages/editor-ui/src/components/WorkerList.ee.vue 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

2 similar comments
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@netroy netroy merged commit 3aa72f6 into master Nov 26, 2024
34 of 37 checks passed
@netroy netroy deleted the fix-workers-view branch November 26, 2024 10:31
netroy pushed a commit that referenced this pull request Nov 26, 2024
@github-actions github-actions bot mentioned this pull request Nov 26, 2024
netroy pushed a commit that referenced this pull request Nov 26, 2024
@github-actions github-actions bot mentioned this pull request Nov 26, 2024
@janober
Copy link
Member

janober commented Nov 26, 2024

Got released with [email protected]

@tomi tomi added the tests-needed This PR needs additional tests label Nov 27, 2024
@github-actions github-actions bot mentioned this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team release/backport Changes that need to be backported to older releases. Released tests-needed This PR needs additional tests ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants