fix(editor): Fix callout component border issue (no-changelog) #11705
+11
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandreini
commented
Nov 12, 2024
| @@ -62,7 +63,7 @@ async function onCloseClick() { | |||
|
|
|||
| <style lang="scss" module> | |||
| .callout { | |||
| height: calc(var(--header-height) * 1px); | |||
| // height: calc(var(--header-height) * 1px); | |||
There was a problem hiding this comment.
@mutdmour what is the reason for this height here?
This increases too much the height of the top banner.
Double-checking with you before removing it.
There was a problem hiding this comment.
it looked weird when the AI Assistant is open. The header of the AI Assistant needed to match both the page header and the banner.
|
Waiting for a feedback from @mutdmour before closing this one |
n8n-assistant
bot
added
n8n team
gandreini
changed the title
|
Removed the fix for the top callout height. Forwarded the issue to Ador to review it. |
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
|
✅ No visual regressions found. |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
dx-171-callout-component-height-and-border-fixes
|
| Run status |
|
| Run duration | 04m 24s |
| Commit |
|
| Committer | Elias Meire |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
469
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
gandreini
deleted the
dx-171-callout-component-height-and-border-fixes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes this issue with the (missing) callout borders:
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/DX-171/callout-component-height-and-border-fixes
closes #DX-171
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)