Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Make task runner oom error message more user friendly (no-changelog) #11646

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

tomi
Copy link
Contributor

@tomi tomi commented Nov 8, 2024

Summary

Based on suggestion by David

image

Related Linear tickets, Github issues, and Community forum posts

https://n8nio.slack.com/archives/C035KBDA917/p1731044690753539?thread_ts=1730730428.450169&cid=C035KBDA917

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@tomi tomi changed the title fix(core): Make task runner oom error message more user friendly fix(core): Make task runner oom error message more user friendly (no-changelog) Nov 8, 2024
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...es/cli/src/runners/errors/task-runner-oom-error.ts 0.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link

cypress bot commented Nov 8, 2024

n8n    Run #7802

Run Properties:  status check passed Passed #7802  •  git commit 0fdb79a270: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Project n8n
Branch Review master
Run status status check passed Passed #7802
Run duration 04m 20s
Commit git commit 0fdb79a270: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Committer Tomi Turtiainen
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 466
View all changes introduced in this branch ↗︎

Copy link
Contributor

github-actions bot commented Nov 8, 2024

✅ All Cypress E2E specs passed

@tomi tomi merged commit 0fdb79a into master Nov 8, 2024
36 checks passed
@tomi tomi deleted the improve-task-runner-oom-error-message branch November 8, 2024 18:27
@janober
Copy link
Member

janober commented Nov 13, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants