feat(core): Improve debugging of sub-workflows #11602
Open
+1,845
−267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
n8n-assistant
bot
added
core
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
RicardoE105
previously approved these changes
Nov 14, 2024
| @@ -25,6 +25,7 @@ | |||
| "start:default": "cd bin && ./n8n", | |||
| "start:windows": "cd bin && n8n", | |||
| "test": "pnpm test:sqlite", | |||
| "test:dev": "N8N_LOG_LEVEL=silent DB_TYPE=sqlite jest --watch", | |||
There was a problem hiding this comment.
Yes, it's very helpful for running tests
| executionId: string; | ||
| workflowId: string; | ||
| } | ||
|
|
||
| export interface ITaskMetadata { |
There was a problem hiding this comment.
Probably not for this PR, but should probably name this something different than taksmetadata
|
|
n8n
|
|||||||||||||||||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
ado-2808-1
|
| Run status |
|
| Run duration | 04m 57s |
| Commit |
|
| Committer | Mutasem Aldmour |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
2
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
473
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
e2e/24-ndv-paired-item.cy.ts • 2 failed tests
| Test | Artifacts | |
|---|---|---|
| NDV > maps paired input and output items |
Test Replay
Screenshots
Video
|
|
| NDV > maps paired input and output items based on selected input node |
Test Replay
Screenshots
Video
|
|
e2e/11-inline-expression-editor.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Inline expression editor > Static data > should resolve array resolvables |
Test Replay
Screenshots
Video
|
|
RicardoE105
approved these changes
Nov 14, 2024
|
|
RicardoE105
previously approved these changes
Nov 14, 2024
|
|
RicardoE105
approved these changes
Nov 14, 2024
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Saves the Execution ID of sub and parent workflows and so makes it now easily possible to jump to the corresponding sub or parent workflow.
based on #8608
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)