Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Include projectId in range query middleware #11590

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Nov 6, 2024

Follow-up to #10976

This was not caught in that PR as those tests were for logic after middleware.

Context: https://n8nio.slack.com/archives/C04B1GZ4T0U/p1730894474755699

Follow-up to #10976

This was not caught there as the tests were for logic after middleware.
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Nov 6, 2024
Copy link

cypress bot commented Nov 6, 2024

n8n    Run #7735

Run Properties:  status check passed Passed #7735  •  git commit 7171ad8140: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project n8n
Branch Review include-projectId-in-range-query-middleware
Run status status check passed Passed #7735
Run duration 04m 30s
Commit git commit 7171ad8140: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Committer Iván Ovejero
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 462
View all changes introduced in this branch ↗︎

Copy link
Contributor

github-actions bot commented Nov 6, 2024

✅ All Cypress E2E specs passed

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@ivov ivov merged commit a6070af into master Nov 6, 2024
34 checks passed
@ivov ivov deleted the include-projectId-in-range-query-middleware branch November 6, 2024 12:50
This was referenced Nov 6, 2024
@janober
Copy link
Member

janober commented Nov 6, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants