Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add SharePoint credentials #11570

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

feelgood-interface
Copy link
Contributor

Summary

Add new OAuth2 credentials for Microsoft SharePoint.

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request in linear Issue or PR has been created in Linear for internal review labels Nov 5, 2024
@Joffcom
Copy link
Member

Joffcom commented Nov 5, 2024

Hey @feelgood-interface,

Thanks for the PR, We have created "GHC-394" as the internal reference to get this reviewed.

One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ntials/MicrosoftSharePointOAuth2Api.credentials.ts 0.00% 8 Missing ⚠️

📢 Thoughts on this report? Let us know!

@feelgood-interface
Copy link
Contributor Author

It might be a good idea to support expressions in the httpRequestNode, then one can use
apiBaseUrl: '=https://{{$credentials.subdomain}}.sharepoint.com/_api/v2.0/'

Copy link
Member

@Joffcom Joffcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Joffcom Joffcom merged commit 05c6109 into n8n-io:master Nov 22, 2024
17 checks passed
@github-actions github-actions bot mentioned this pull request Nov 27, 2024
@janober
Copy link
Member

janober commented Nov 27, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member in linear Issue or PR has been created in Linear for internal review node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants