Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Zabbix credential only node #11489

Merged
merged 14 commits into from
Nov 22, 2024

Conversation

adina-hub
Copy link
Contributor

Summary

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@CLAassistant
Copy link

CLAassistant commented Oct 31, 2024

CLA assistant check
All committers have signed the CLA.

@n8n-assistant n8n-assistant bot added community Authored by a community member in linear Issue or PR has been created in Linear for internal review labels Oct 31, 2024
@Joffcom
Copy link
Member

Joffcom commented Oct 31, 2024

Hey @adina-hub,

Thanks for the PR, We have created "GHC-371" as the internal reference to get this reviewed.

One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team.

@adina-hub adina-hub changed the title WIP: Add credentials zabbix Add credentials zabbix Nov 6, 2024
Copy link
Member

@Joffcom Joffcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some notes, As the ZabbixAuthApi is using a deprecated method we should probably skip it and only move forward with the API token optoin.

@Joffcom
Copy link
Member

Joffcom commented Nov 20, 2024

@adina-hub the credential test still returns a success if the toke is incorrect or missing. Everything else looks good though, I have been testing against a self hosted Zabbix instance and Zabbix Cloud.

@adina-hub
Copy link
Contributor Author

@Joffcom Last changes are pushed, credentials were tested again, now it works.

@Joffcom Joffcom changed the title Add credentials zabbix feat: Add Zabbix credential only node Nov 22, 2024
@Joffcom
Copy link
Member

Joffcom commented Nov 22, 2024

@adina-hub that is perfect thanks 🙏🏻

Copy link
Member

@Joffcom Joffcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good thanks.

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...es/nodes-base/credentials/ZabbixApi.credentials.ts 0.00% 9 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Joffcom Joffcom merged commit fbd1ecf into n8n-io:master Nov 22, 2024
18 checks passed
@github-actions github-actions bot mentioned this pull request Nov 27, 2024
@janober
Copy link
Member

janober commented Nov 27, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member in linear Issue or PR has been created in Linear for internal review Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants