Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Support middle click to scroll when using a mouse on new canvas #11384

Merged

Conversation

alexgrozav
Copy link
Member

Summary

Dirty fix, creating upstream issue to vueflow.

Screen.Recording.2024-10-24.at.12.11.03.mov

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/N8N-7585/support-middle-click-to-scroll-when-using-a-mouse

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@alexgrozav alexgrozav self-assigned this Oct 24, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Oct 24, 2024
Copy link

cypress bot commented Oct 24, 2024

n8n    Run #7549

Run Properties:  status check passed Passed #7549  •  git commit 84e165699b: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project n8n
Branch Review n8n-7585-support-middle-click-to-scroll-when-using-a-mouse
Run status status check passed Passed #7549
Run duration 04m 22s
Commit git commit 84e165699b: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Committer Alex Grozav
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 458
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav merged commit 46f3b4a into master Oct 24, 2024
33 checks passed
@alexgrozav alexgrozav deleted the n8n-7585-support-middle-click-to-scroll-when-using-a-mouse branch October 24, 2024 13:51
@alexgrozav alexgrozav added required for next release release/backport Changes that need to be backported to older releases. and removed required for next release labels Oct 24, 2024
This was referenced Oct 28, 2024
@janober
Copy link
Member

janober commented Oct 29, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team release/backport Changes that need to be backported to older releases. Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants