fix(core): Change dedupe value column type from varchar(255) to text #11357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShireenMissi
added
release/backport
tomi
reviewed
Oct 23, 2024
...es/cli/src/databases/migrations/common/1729607673464-UpdateProcessedDataValueColumnToText.ts
Outdated
Show resolved
Hide resolved
...es/cli/src/databases/migrations/common/1729607673464-UpdateProcessedDataValueColumnToText.ts
Outdated
Show resolved
Hide resolved
ShireenMissi
force-pushed
the
node-1899-deduplication-node-throws-value-too-long-for-type-character
branch
from
518c178
to
aa65727
Compare
ShireenMissi
force-pushed
the
node-1899-deduplication-node-throws-value-too-long-for-type-character
branch
from
aa65727
to
04861e9
Compare
tomi
approved these changes
Oct 23, 2024
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
node-1899-deduplication-node-throws-value-too-long-for-type-character
|
| Run status |
|
| Run duration | 04m 20s |
| Commit |
|
| Committer | Shireen Missi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
458
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
ShireenMissi
deleted the
node-1899-deduplication-node-throws-value-too-long-for-type-character
branch
r00gm
pushed a commit
that referenced
this pull request
Oct 24, 2024
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the type of the value column from varchar(255) to text
As sqlite has limited support for changing column, the change is done by adding and dropping columns only
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1899/deduplication-node-throws-value-too-long-for-type-character
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)