Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Enforce nodejs version consistently #11323

Merged
merged 2 commits into from
Oct 21, 2024
Merged

fix(core): Enforce nodejs version consistently #11323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b32ad0
fix(core): Enforce nodejs version consistently
netroy Oct 21, 2024
0e74dd0
address PR comments
netroy Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 14 additions & 15 deletions packages/cli/bin/n8n
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,21 +18,20 @@ if (process.argv.length === 2) {
process.argv.push('start');
}

const nodeVersion = process.versions.node;
const { major, gte } = require('semver');

const MINIMUM_SUPPORTED_NODE_VERSION = '18.17.0';
const ENFORCE_MIN_NODE_VERSION = process.env.E2E_TESTS !== 'true';

if (
(ENFORCE_MIN_NODE_VERSION && !gte(nodeVersion, MINIMUM_SUPPORTED_NODE_VERSION)) ||
![18, 20, 22].includes(major(nodeVersion))
) {
console.log(`
Your Node.js version ${nodeVersion} is currently not supported by n8n.
Please use Node.js v${MINIMUM_SUPPORTED_NODE_VERSION} (recommended), v20, or v22 instead!
`);
process.exit(1);
const ENFORCE_NODE_VERSION_RANGE = process.env.E2E_TESTS !== 'true';
if (ENFORCE_NODE_VERSION_RANGE) {
const satisfies = require('semver/functions/satisfies');
const nodeVersion = process.versions.node;
const {
engines: { node: supportedNodeVersions },
} = require('../package.json');
if (!satisfies(nodeVersion, supportedNodeVersions)) {
console.error(`
Your Node.js version ${nodeVersion} is currently not supported by n8n.
Please use a Node.js version that satisfies the following version range: ${supportedNodeVersions}
`);
process.exit(1);
}
}

// Disable nodejs custom inspection across the app
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"workflow"
],
"engines": {
"node": ">=18.10"
"node": ">=18.17 <= 22"
},
"files": [
"bin",
Expand Down
Loading