Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AI Transform Node): Support for drag and drop #11276

Merged
merged 27 commits into from
Nov 27, 2024

Conversation

michael-radency
Copy link
Contributor

Summary

Allow dragging data pills from the input to insert the field name

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1863/input-fields-dragging

@michael-radency michael-radency added node/improvement New feature or request n8n team Authored by the n8n team labels Oct 16, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 13.09524% with 146 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../editor-ui/src/components/ButtonParameter/utils.ts 3.14% 123 Missing ⚠️
...src/components/ButtonParameter/ButtonParameter.vue 43.90% 23 Missing ⚠️

📢 Thoughts on this report? Let us know!

border: 1.5px dashed var(--color-ndv-droppable-parameter) !important;
}
.activeDrop {
border: 1.5px solid var(--color-success) !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be done without !important ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, we need to override defaults of N8nInput(ElInput)

@@ -227,7 +276,7 @@ onMounted(() => {

<style module lang="scss">
.input * {
border: 0 !important;
border: 1.5px transparent !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be done without !important ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, we need to override defaults of N8nInput(ElInput)

Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Nov 27, 2024

n8n    Run #8117

Run Properties:  status check passed Passed #8117  •  git commit b26ccb0c91: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project n8n
Branch Review node-1863-input-fields-dragging
Run status status check passed Passed #8117
Run duration 04m 40s
Commit git commit b26ccb0c91: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Committer Michael Kret
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 478
View all changes introduced in this branch ↗︎

@michael-radency michael-radency merged commit 2c252b0 into master Nov 27, 2024
75 of 79 checks passed
@michael-radency michael-radency deleted the node-1863-input-fields-dragging branch November 27, 2024 10:42
@github-actions github-actions bot mentioned this pull request Nov 27, 2024
@janober
Copy link
Member

janober commented Nov 27, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants