Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Organize all event maps #10997

Merged
merged 3 commits into from
Sep 30, 2024
Merged

refactor(core): Organize all event maps #10997

merged 3 commits into from
Sep 30, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Sep 27, 2024 •
edited
Loading

Quick small refactor to bring all event maps under @/events/maps and all relays under @/events/relays as setup for extracting out and testing all pub sub message handlers.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Sep 27, 2024
ivov
ivov commented Sep 27, 2024
View reviewed changes
packages/cli/src/scaling/pubsub/pubsub.types.ts

namespace Command {
namespace Commands {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plural to prevent overlap with type.

@cypress Cypress
Copy link

cypress bot commented Sep 30, 2024

n8n    Run #7088

Run Properties:  status check passed Passed #7088  •  git commit e78b8d4eec: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project n8n
Branch Review organize-all-event-maps
Run status status check passed Passed #7088
Run duration 04m 28s
Commit git commit e78b8d4eec: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Committer Iván Ovejero
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 435
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit 63e6f1f into master Sep 30, 2024
35 checks passed
@ivov ivov deleted the organize-all-event-maps branch September 30, 2024 08:44
MiloradFilipovic added a commit that referenced this pull request Sep 30, 2024
@MiloradFilipovic
Merge branch 'master' into ADO-2659-context-to-support-chat
958fc56 
* master:
  feat(editor): Overhaul document title management (#10999)
  refactor(core): Organize all event maps (#10997)
  fix(AI Agent Node): Fix output parsing and empty tool input handling in AI Agent node (#10970)
@janober
Copy link
Member

janober commented Oct 2, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netroy netroy netroy approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivov @janober @netroy