Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): Migrate community nodes modals to composition api (no-changelog) #10909

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

MiloradFilipovic
Copy link
Contributor

Migrating CommunityPackageInstallModal and CommunityPackageManageConfirmModal to composition api.

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@MiloradFilipovic MiloradFilipovic self-assigned this Sep 20, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Sep 20, 2024
@MiloradFilipovic MiloradFilipovic changed the title refactor(editor): Migrate community nodes modals to composition api refactor(editor): Migrate community nodes modals to composition api (no-changelog) Sep 23, 2024
Copy link

cypress bot commented Sep 23, 2024

n8n    Run #7008

Run Properties:  status check passed Passed #7008  •  git commit e3bd1d65ff: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Project n8n
Branch Review community-nodes-modals-composition-api
Run status status check passed Passed #7008
Run duration 04m 40s
Commit git commit e3bd1d65ff: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Committer Ricardo Espinoza
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 430
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@MiloradFilipovic MiloradFilipovic merged commit f9515b9 into master Sep 23, 2024
33 checks passed
@MiloradFilipovic MiloradFilipovic deleted the community-nodes-modals-composition-api branch September 23, 2024 15:28
riascho pushed a commit that referenced this pull request Sep 24, 2024
@janober
Copy link
Member

janober commented Sep 25, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants