-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ensure user id for early track events #10885
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I left a comment with a question but might be unrelevant
@@ -146,6 +144,10 @@ export class Telemetry { | |||
} | |||
} | |||
|
|||
reset() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also a call to rudderStack.reset
in identify
action (here). Do we still need that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we still need that when initializing RS if user is not logged in.
Got released with |
Summary
Related Linear tickets, Github issues, and Community forum posts
Fixes ADO-2438
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)